Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

core: fix crash because of bracket in note search query (#9477)

01zulfi95a9775c26c2
diff --git a/packages/core/__tests__/lookup.test.js b/packages/core/__tests__/lookup.test.js
index 6d70f7bc7..30d470f22 100644
--- a/packages/core/__tests__/lookup.test.js
+++ b/packages/core/__tests__/lookup.test.js
@@ -153,4 +153,17 @@ describe("notesWithHighlighting", () => {
const item = await filtered.item(0);
expect(item.item).toBeDefined();
}));
+
+ test("search notes with brackets in query should load the item", () =>
+ noteTest({
+ title: "[with brackets]"
+ }).then(async ({ db }) => {
+ await db.notes.add(TEST_NOTE);
+ const filtered = await db.lookup.notesWithHighlighting(
+ "[with brackets]",
+ db.notes.all
+ );
+ const item = await filtered.item(0);
+ expect(item.item).toBeDefined();
+ }));
});
diff --git a/packages/core/src/api/lookup.ts b/packages/core/src/api/lookup.ts
index 46234a097..5e3e0af19 100644
--- a/packages/core/src/api/lookup.ts
+++ b/packages/core/src/api/lookup.ts
@@ -1154,7 +1154,7 @@ function textContainsTokens(text: string, tokens: QueryTokens) {
const lowerCasedText = text.toLowerCase();
const createTagPattern = (token: string) => {
- const escapedToken = token.replace(/[()]/g, "\\$&");
+ const escapedToken = token.replace(/[()[\]]/g, "\\$&");
return `<${MATCH_TAG_NAME}\\s+id="(.+?)">${escapedToken}<\\/${MATCH_TAG_NAME}>`;
};