Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

web: fix reminder tests

Abdullah Attaa4371257309b
diff --git a/apps/web/__e2e__/models/utils.ts b/apps/web/__e2e__/models/utils.ts
index b5642a474..0564862d7 100644
--- a/apps/web/__e2e__/models/utils.ts
+++ b/apps/web/__e2e__/models/utils.ts
@@ -47,7 +47,7 @@ export async function fillReminderDialog(
page: Page,
reminder: Partial<Reminder>
) {
- const dialog = page.locator(getTestId("reminder-dialog"));
+ const dialog = page.locator(getTestId("add-reminder-dialog"));
const titleInput = dialog.locator(getTestId("title-input"));
const descriptionInput = dialog.locator(getTestId("description-input"));
const dateInput = dialog.locator(getTestId("date-input"));
diff --git a/apps/web/src/components/reminder/index.tsx b/apps/web/src/components/reminder/index.tsx
index e8cb08376..99806b420 100644
--- a/apps/web/src/components/reminder/index.tsx
+++ b/apps/web/src/components/reminder/index.tsx
@@ -108,7 +108,7 @@ function Reminder(props: ReminderProps) {
}
export default React.memo(Reminder, (prev, next) => {
- return prev?.item?.title === next?.item?.title;
+ return prev.item.dateModified === next.item.dateModified;
});
const menuItems: (reminder: ReminderType, items?: string[]) => MenuItem[] = (
@@ -133,7 +133,7 @@ const menuItems: (reminder: ReminderType, items?: string[]) => MenuItem[] = (
id: reminder.id,
disabled: !reminder.disabled
});
- store.refresh();
+ await store.refresh();
}
},
{ key: "sep", type: "separator" },
diff --git a/apps/web/src/dialogs/add-reminder-dialog.tsx b/apps/web/src/dialogs/add-reminder-dialog.tsx
index fc628f966..3fc2ccc17 100644
--- a/apps/web/src/dialogs/add-reminder-dialog.tsx
+++ b/apps/web/src/dialogs/add-reminder-dialog.tsx
@@ -152,7 +152,7 @@ export default function AddReminderDialog(props: AddReminderDialogProps) {
<Dialog
isOpen={true}
title={reminderId ? "Edit reminder" : "Add a reminder"}
- description={""}
+ testId="add-reminder-dialog"
onClose={() => props.onClose(false)}
positiveButton={{
text: reminderId ? "Save" : "Add",
diff --git a/nx.json b/nx.json
index a22e61540..82f53af62 100644
--- a/nx.json
+++ b/nx.json
@@ -66,5 +66,6 @@
"sharedGlobals": [],
"production": ["default"]
},
+ "parallel": 4,
"nxCloudAccessToken": "ZWM3ODgxNDgtNGUzZC00MjQ0LWE3MzMtZDdhMzE3ZGY2MWFlfHJlYWQ="
}
diff --git a/packages/core/src/collections/reminders.ts b/packages/core/src/collections/reminders.ts
index 966cccbff..9bfe47f4f 100644
--- a/packages/core/src/collections/reminders.ts
+++ b/packages/core/src/collections/reminders.ts
@@ -57,7 +57,7 @@ export class Reminders implements ICollection {
throw new Error("Please use db.reminders.merge to merge reminders.");
const id = reminder.id || getId();
- const oldReminder = this.collection.get(id);
+ const oldReminder = await this.collection.get(id);
reminder = {
...oldReminder,