Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

mobile: convert heic/heif images to jpeg

Ammar Ahmedadf0f132fd75
diff --git a/apps/mobile/app/screens/editor/tiptap/picker.ts b/apps/mobile/app/screens/editor/tiptap/picker.ts
index 52a67cb12..4cc44b616 100644
--- a/apps/mobile/app/screens/editor/tiptap/picker.ts
+++ b/apps/mobile/app/screens/editor/tiptap/picker.ts
@@ -185,7 +185,8 @@ const camera = async (options: PickerOptions) => {
cropping: false,
multiple: true,
maxFiles: 10,
- writeTempFile: true
+ writeTempFile: true,
+ compressImageQuality: 1
})
.then((response) => {
handleImageResponse(
@@ -215,7 +216,8 @@ const gallery = async (options: PickerOptions) => {
mediaType: "photo",
maxFiles: 10,
cropping: false,
- multiple: true
+ multiple: true,
+ compressImageQuality: 1
})
.then((response) =>
handleImageResponse(
@@ -266,7 +268,6 @@ const handleImageResponse = async (
response: Image[],
options: PickerOptions
) => {
- console.log(response, "result-file-picker");
const result = await AttachImage.present(response, options.context);
if (!result) return;
const compress = result.compress;
diff --git a/apps/mobile/patches/react-native-image-crop-picker+0.40.2.patch b/apps/mobile/patches/react-native-image-crop-picker+0.40.2.patch
index e410f3010..d80f7eaa1 100644
--- a/apps/mobile/patches/react-native-image-crop-picker+0.40.2.patch
+++ b/apps/mobile/patches/react-native-image-crop-picker+0.40.2.patch
@@ -10,3 +10,19 @@ index 5de0845..1b158d8 100644
if (includeBase64) {
image.putString("data", getBase64StringFromFile(compressedImagePath));
+diff --git a/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m b/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m
+index 9f20973..5e14da8 100644
+--- a/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m
++++ b/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m
+@@ -595,8 +595,10 @@ - (void)qb_imagePickerController:
+ NSString *mimeType = [self determineMimeTypeFromImageData:imageData];
+ Boolean isKnownMimeType = [mimeType length] > 0;
+
++ Boolean isHeicOrHeif = [mimeType isEqualToString:@"image/heic"] || [mimeType isEqualToString:@"image/heif"];
++
+ ImageResult *imageResult = [[ImageResult alloc] init];
+- if (isLossless && useOriginalWidth && useOriginalHeight && isKnownMimeType && !forceJpg) {
++ if (isLossless && useOriginalWidth && useOriginalHeight && isKnownMimeType && !forceJpg && !isHeicOrHeif) {
+ // Use original, unmodified image
+ imageResult.data = imageData;
+ imageResult.width = @(imgT.size.width);