Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

mobile: use shallow selector for auto-backup hooks to stop infinite re-render loop

kashaf-ansari-devb8ed559700ab
diff --git a/apps/mobile/app/screens/settings/settings-data.tsx b/apps/mobile/app/screens/settings/settings-data.tsx
index 7b04ed38f..54cd511d2 100644
--- a/apps/mobile/app/screens/settings/settings-data.tsx
+++ b/apps/mobile/app/screens/settings/settings-data.tsx
@@ -83,6 +83,7 @@ import { verifyUser, verifyUserWithApplock } from "./functions";
import { logoutUser } from "./logout";
import { SettingSection } from "./types";
import { getTimeLeft } from "./user-section";
+import { useShallow } from "zustand/react/shallow";
export function getSettingsGroups(): SettingSection[] {
return [
@@ -1466,10 +1467,12 @@ export function getSettingsGroups(): SettingSection[] {
type: "component",
name: strings.automaticBackups(),
useHook: () =>
- useSettingStore((state) => [
- state.settings.reminder,
- state.settings.lastBackupDate
- ]),
+ useSettingStore(
+ useShallow((state) => [
+ state.settings.reminder,
+ state.settings.lastBackupDate
+ ])
+ ),
description: () => {
const next = BackupService.getNextBackupTime(
SettingsService.get().reminder,
@@ -1489,10 +1492,12 @@ export function getSettingsGroups(): SettingSection[] {
hidden: () => !useUserStore.getState().user,
name: strings.automaticBackupsWithAttachments(),
useHook: () =>
- useSettingStore((state) => [
- state.settings.fullBackupReminder,
- state.settings.lastFullBackupDate
- ]),
+ useSettingStore(
+ useShallow((state) => [
+ state.settings.fullBackupReminder,
+ state.settings.lastFullBackupDate
+ ])
+ ),
description: () => {
const next = BackupService.getNextBackupTime(
SettingsService.get().fullBackupReminder,