Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

ci: run desktop macos x64 tests on macos-13 runner

Abdullah Attadafc2de2b32a
diff --git a/.github/workflows/desktop.tests.yml b/.github/workflows/desktop.tests.yml
index 6b4e63401..b8e1de421 100644
--- a/.github/workflows/desktop.tests.yml
+++ b/.github/workflows/desktop.tests.yml
@@ -40,10 +40,10 @@ jobs:
name: build
path: apps/web/build/**/*
- test-macos:
- name: Test macOS
+ test-macos-x64:
+ name: Test macOS x64
needs: build
- runs-on: macos-latest
+ runs-on: macos-13
steps:
- name: Check out Git repository
@@ -63,19 +63,58 @@ jobs:
npm ci --ignore-scripts --prefer-offline --no-audit
npm run bootstrap -- --scope=desktop
- - name: Install sqlite-better-trigram for all arch
+ - name: Build Electron wrapper
+ run: npx nx run release --project @notesnook/desktop
+ working-directory: ./apps/desktop
+
+ - name: Build app
run: |
- npm i --cpu arm64 sqlite-better-trigram
- npm i --cpu x64 sqlite-better-trigram
+ yarn electron-builder --mac --dir --x64
+ working-directory: ./apps/desktop
+
+ - name: Run tests x64
+ run: |
+ EXECUTABLE_PATH=output/mac/Notesnook.app/Contents/MacOS/Notesnook npm run test
working-directory: ./apps/desktop
+ - name: Upload test results
+ uses: actions/upload-artifact@v4
+ if: failure()
+ with:
+ name: test-results-macos-x64
+ path: apps/desktop/test-results
+ retention-days: 5
+
+ test-macos:
+ name: Test macOS
+ needs: build
+ runs-on: macos-latest
+
+ steps:
+ - name: Check out Git repository
+ uses: actions/checkout@v4
+
+ - name: Setup Node
+ uses: ./.github/actions/setup-node-with-cache
+
+ - name: Download build
+ uses: actions/download-artifact@v4
+ with:
+ name: build
+ path: ./apps/web/build
+
+ - name: Install packages
+ run: |
+ npm ci --ignore-scripts --prefer-offline --no-audit
+ npm run bootstrap -- --scope=desktop
+
- name: Build Electron wrapper
run: npx nx run release --project @notesnook/desktop
working-directory: ./apps/desktop
- name: Build app
run: |
- yarn electron-builder --mac --dir --arm64 --x64
+ yarn electron-builder --mac --dir --arm64
working-directory: ./apps/desktop
- name: Run tests arm64
@@ -83,11 +122,6 @@ jobs:
EXECUTABLE_PATH=output/mac-arm64/Notesnook.app/Contents/MacOS/Notesnook npm run test
working-directory: ./apps/desktop
- - name: Run tests x64
- run: |
- EXECUTABLE_PATH=output/mac/Notesnook.app/Contents/MacOS/Notesnook npm run test
- working-directory: ./apps/desktop
-
- name: Upload test results
uses: actions/upload-artifact@v4
if: failure()
@@ -139,6 +173,14 @@ jobs:
EXECUTABLE_PATH=output/linux-unpacked/notesnook xvfb-run --auto-servernum --server-args="-screen 0 1920x1080x24" -- npm run test
working-directory: ./apps/desktop
+ - name: Upload test results
+ uses: actions/upload-artifact@v4
+ if: failure()
+ with:
+ name: test-results-linux
+ path: apps/desktop/test-results
+ retention-days: 5
+
test-windows:
name: Test for Windows
needs: build
@@ -181,3 +223,11 @@ jobs:
run: |
npx cross-env EXECUTABLE_PATH=output/win-unpacked/Notesnook.exe npm run test
working-directory: ./apps/desktop
+
+ - name: Upload test results
+ uses: actions/upload-artifact@v4
+ if: failure()
+ with:
+ name: test-results-win
+ path: apps/desktop/test-results
+ retention-days: 5