Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

editor: disallow embedding javascript code in iframes

Abdullah Attadf74448e17ae
diff --git a/packages/editor/src/extensions/embed/component.tsx b/packages/editor/src/extensions/embed/component.tsx
index 8ff008be5..6b2ac8ee9 100644
--- a/packages/editor/src/extensions/embed/component.tsx
+++ b/packages/editor/src/extensions/embed/component.tsx
@@ -115,9 +115,10 @@ export function EmbedComponent(
</Box>
<Embed
ref={embedRef}
- src={src}
+ src={src.startsWith("javascript:") ? "about:blank" : src}
width={"100%"}
height={"100%"}
+ sandbox="allow-scripts"
sx={{
bg: "var(--background-secondary)",
border: selected
diff --git a/packages/editor/src/toolbar/popups/embed-popup.tsx b/packages/editor/src/toolbar/popups/embed-popup.tsx
index 944a08180..044aebd27 100644
--- a/packages/editor/src/toolbar/popups/embed-popup.tsx
+++ b/packages/editor/src/toolbar/popups/embed-popup.tsx
@@ -101,6 +101,9 @@ export function EmbedPopup(props: EmbedPopupProps) {
}
const convertedUrl = convertUrlToEmbedUrl(_src);
if (convertedUrl) _src = convertedUrl;
+ if (_src.startsWith("javascript:")) {
+ return setError("Embedding javascript code is not supported.");
+ }
onClose({
height: _height,
width: _width,