Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

editor: fix crash on dragging a react node

Abdullah Attae150e08f29a6
diff --git a/packages/editor/src/extensions/react/react-node-view.tsx b/packages/editor/src/extensions/react/react-node-view.tsx
index 4c23e41be..2aead5c8c 100644
--- a/packages/editor/src/extensions/react/react-node-view.tsx
+++ b/packages/editor/src/extensions/react/react-node-view.tsx
@@ -264,17 +264,11 @@ export class ReactNodeView<P extends ReactNodeViewProps> implements NodeView {
const { view } = this.editor;
const target = event.target as HTMLElement;
- // get the drag handle element
- // `closest` is not available for text nodes so we may have to use its parent
- const dragHandle =
- target.nodeType === 3
- ? target.parentElement?.closest("[data-drag-handle]")
- : target.closest("[data-drag-handle]");
+ const dragHandle = this.dom.querySelector("[data-drag-handle]");
+ const dragImage = this.dom.querySelector("[data-drag-image]") || this.dom;
if (!this.dom || this.contentDOM?.contains(target) || !dragHandle) return;
- const dragImage = this.dom.querySelector("[data-drag-image]") || this.dom;
-
// workaround to prevent opening of keyboard on drag start
if (isAndroid || isiOS) {
setTimeout(() => {