Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

editor: escape html in twitter embed src (#9326)

01zulfie87f5e5f899f
diff --git a/packages/editor/src/extensions/embed/component.tsx b/packages/editor/src/extensions/embed/component.tsx
index 999c570bf..4e22eaabb 100644
--- a/packages/editor/src/extensions/embed/component.tsx
+++ b/packages/editor/src/extensions/embed/component.tsx
@@ -206,7 +206,13 @@ function isTwitterX(src: string) {
function tweetToEmbed(src: string, isDarkTheme: boolean) {
src = src.replaceAll("x.com", "twitter.com");
+
+ const anchor = document.createElement("a");
+ anchor.href = `${src}?ref_src=twsrc%5Etfw`;
+
return `<blockquote class="twitter-tweet" data-dnt="true" ${
isDarkTheme ? 'data-theme="dark"' : ""
- }><p lang="en" dir="ltr"><a href="${src}?ref_src=twsrc%5Etfw"></a></blockquote> <script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script> `;
+ }><p lang="en" dir="ltr">${
+ anchor.outerHTML
+ }</p></blockquote> <script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script> `;
}