Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

webclipper: fix bookmark not working in web clipper

Abdullah Attaf2e91d4a5c54
diff --git a/extensions/web-clipper/src/views/main.tsx b/extensions/web-clipper/src/views/main.tsx
index 3aed3a7ab..8f99a1d32 100644
--- a/extensions/web-clipper/src/views/main.tsx
+++ b/extensions/web-clipper/src/views/main.tsx
@@ -466,22 +466,24 @@ export function Main() {
disabled={isClipping}
onClick={async () => {
if (
- clipperState === ClipperState.Idle ||
- clipperState === ClipperState.Error
+ clipMode !== "bookmark" &&
+ (clipperState === ClipperState.Idle ||
+ clipperState === ClipperState.Error)
) {
await startClip();
return;
}
- const isBookmark = clipMode === "bookmark";
- const data = isBookmark
- ? {
- data: `<a href="${url}">${title}</a>`
- }
- : clipData;
+ if (!title || !clipArea || !clipMode || !url) return;
- if (!data || !clipData || !title || !clipArea || !clipMode || !url)
- return;
+ const data =
+ clipMode === "bookmark"
+ ? {
+ data: createBookmark(url, title)
+ }
+ : clipData;
+
+ if (!data) return;
const notesnook = await connectApi(false);
if (!notesnook) {
@@ -589,3 +591,11 @@ export async function clip(
settings
});
}
+
+function createBookmark(url: string, title: string) {
+ const a = document.createElement("a");
+ a.setAttribute("href", url);
+ a.setAttribute("title", title);
+ a.innerText = title;
+ return a.outerHTML;
+}