Skip to content

Open-source SEO, GEO, and marketing skills for AI agents.

chore(notfair-cmo): drop NOTFAIR_BROWSER_IDLE_DISABLED flag

Yuting Zhong684a156f0fac
diff --git a/notfair-cmo/src/server/browser/session.test.ts b/notfair-cmo/src/server/browser/session.test.ts
index e7cfc33a..56320183 100644
--- a/notfair-cmo/src/server/browser/session.test.ts
+++ b/notfair-cmo/src/server/browser/session.test.ts
@@ -58,10 +58,10 @@ function makeFakeBrowser(): { browser: Browser; context: BrowserContext; closed:
beforeEach(() => {
process.env.NOTFAIR_CMO_DATA_DIR = "/tmp/notfair-cmo-test";
process.env.NOTFAIR_CHROME_PATH = "/usr/bin/fake-chrome";
- // Disable the idle ticker globally so tests that don't exercise it
- // never get surprise shutdowns mid-assertion.
- process.env.NOTFAIR_BROWSER_IDLE_DISABLED = "1";
_sessionsByProject.clear();
+ // Cancel any leftover ticker so cross-test interactions are deterministic.
+ // The ticker fires every 30s; test durations are <1s, so we're not racing
+ // mid-test, but we still keep the slate clean.
_stopIdleChecker();
});
@@ -70,7 +70,6 @@ afterEach(async () => {
_stopIdleChecker();
delete process.env.NOTFAIR_CMO_DATA_DIR;
delete process.env.NOTFAIR_CHROME_PATH;
- delete process.env.NOTFAIR_BROWSER_IDLE_DISABLED;
delete process.env.NOTFAIR_BROWSER_IDLE_TIMEOUT_MS;
});
diff --git a/notfair-cmo/src/server/browser/session.ts b/notfair-cmo/src/server/browser/session.ts
index 3a6794dd..ae556001 100644
--- a/notfair-cmo/src/server/browser/session.ts
+++ b/notfair-cmo/src/server/browser/session.ts
@@ -14,8 +14,7 @@
* cached session so the next browser_open relaunches.
* 4. Idle auto-shutdown: a 30s tick checks for sessions with no
* activity (no getOrLaunchBrowser call) in the last
- * NOTFAIR_BROWSER_IDLE_TIMEOUT_MS (default 5 minutes). Disable
- * with NOTFAIR_BROWSER_IDLE_DISABLED=1.
+ * NOTFAIR_BROWSER_IDLE_TIMEOUT_MS (default 5 minutes).
*/
import type { Browser, BrowserContext } from "playwright-core";
@@ -255,13 +254,10 @@ let _idleCheckerInterval: ReturnType<typeof setInterval> | null = null;
* Start the periodic idle check. Idempotent — call freely. The Node
* interval is .unref'd so it never keeps the process alive on its own.
*
- * Disable with NOTFAIR_BROWSER_IDLE_DISABLED=1 (useful for tests that
- * want manual control, or for users who want Chrome to stay warm
- * indefinitely).
+ * Tests cancel via _stopIdleChecker() in afterEach.
*/
export function ensureIdleChecker(): void {
if (_idleCheckerInterval) return;
- if (process.env.NOTFAIR_BROWSER_IDLE_DISABLED === "1") return;
_idleCheckerInterval = setInterval(() => {
void checkIdleSessions();
}, IDLE_CHECK_INTERVAL_MS);