Skip to content

Open-source SEO, GEO, and marketing skills for AI agents.

fix(notfair-cmo): remove browser_shutdown from agent MCP surface

Yuting Zhonge5fc20d0cf7d
diff --git a/notfair-cmo/src/server/mcp-server/browser-tools.test.ts b/notfair-cmo/src/server/mcp-server/browser-tools.test.ts
index ee3e16cd..53684d3c 100644
--- a/notfair-cmo/src/server/mcp-server/browser-tools.test.ts
+++ b/notfair-cmo/src/server/mcp-server/browser-tools.test.ts
@@ -15,7 +15,6 @@ vi.mock("@/server/browser/session", () => ({
launchedAt: 1_000,
uptimeMs: 5_000,
})),
- stopBrowser: vi.fn(async () => {}),
}));
vi.mock("@/server/browser/tabs", () => ({
@@ -74,7 +73,7 @@ afterEach(() => {
// ── Registry shape ─────────────────────────────────────────────────────
describe("BROWSER_TOOLS registry", () => {
- it("exposes exactly the 12 expected tools (status, tabs, open, close, navigate, snapshot, click, type, press, scroll, back, shutdown)", () => {
+ it("exposes exactly the 11 expected tools (no shutdown — that's intentionally user-only)", () => {
expect(BROWSER_TOOLS.map((t) => t.name).sort()).toEqual(
[
"browser_back",
@@ -84,7 +83,6 @@ describe("BROWSER_TOOLS registry", () => {
"browser_open",
"browser_press",
"browser_scroll",
- "browser_shutdown",
"browser_snapshot",
"browser_status",
"browser_tabs",
@@ -93,6 +91,11 @@ describe("BROWSER_TOOLS registry", () => {
);
});
+ it("does NOT expose browser_shutdown to agents (multi-agent safety: any agent calling it would kill Chrome for the others)", () => {
+ const names = BROWSER_TOOLS.map((t) => t.name);
+ expect(names).not.toContain("browser_shutdown");
+ });
+
it("each tool ships a non-empty description and a zod inputSchema", () => {
for (const t of BROWSER_TOOLS) {
expect(t.description.length).toBeGreaterThan(20);
@@ -347,7 +350,7 @@ describe("browser_scroll", () => {
});
});
-// ── browser_back / browser_shutdown ────────────────────────────────────
+// ── browser_back ───────────────────────────────────────────────────────
describe("browser_back", () => {
it("invokes actions.back", async () => {
@@ -359,11 +362,3 @@ describe("browser_back", () => {
expect(actions.back).toHaveBeenCalledOnce();
});
});
-
-describe("browser_shutdown", () => {
- it("calls stopBrowser and reports success", async () => {
- const result = await tool("browser_shutdown").handler({ project_slug: "acme" }, {});
- expect(result.ok).toBe(true);
- expect(session.stopBrowser).toHaveBeenCalledWith("acme");
- });
-});
diff --git a/notfair-cmo/src/server/mcp-server/browser-tools.ts b/notfair-cmo/src/server/mcp-server/browser-tools.ts
index e477d5ef..a8fba41c 100644
--- a/notfair-cmo/src/server/mcp-server/browser-tools.ts
+++ b/notfair-cmo/src/server/mcp-server/browser-tools.ts
@@ -19,7 +19,7 @@ import {
type as actType,
type SnapshotElement,
} from "@/server/browser/actions";
-import { getOrLaunchBrowser, getSessionStatus, stopBrowser } from "@/server/browser/session";
+import { getOrLaunchBrowser, getSessionStatus } from "@/server/browser/session";
import { closeTab, getTab, listTabs, openTab } from "@/server/browser/tabs";
import type { ToolDefinition, ToolResult } from "./tools";
@@ -352,20 +352,12 @@ async function handleBrowserBack(input: unknown): Promise<ToolResult> {
return result;
}
-// ── browser_shutdown (admin) ───────────────────────────────────────────
-
-const browserShutdownInput = z.object({ project_slug: projectSlug });
-
-async function handleBrowserShutdown(input: unknown): Promise<ToolResult> {
- const parsed = browserShutdownInput.safeParse(input);
- if (!parsed.success) return invalid(parsed.error);
- try {
- await stopBrowser(parsed.data.project_slug);
- return txt(`Workspace browser for "${parsed.data.project_slug}" stopped.`);
- } catch (err) {
- return fail(`browser_shutdown failed: ${safeMessage(err)}`);
- }
-}
+// browser_shutdown is intentionally NOT exposed as an agent tool. With multiple
+// agents sharing one workspace Chrome, any agent calling shutdown would kill
+// the browser out from under the others mid-task. Browser lifecycle stays
+// owned by the user (Settings → Workspace browser → Stop) and by process exit
+// hooks. The /api/browser/shutdown route imports stopBrowser directly from
+// session.ts; agents do not get this primitive.
// ── Helpers ────────────────────────────────────────────────────────────
@@ -457,11 +449,4 @@ export const BROWSER_TOOLS: ToolDefinition[] = [
inputSchema: browserBackInput,
handler: handleBrowserBack,
},
- {
- name: "browser_shutdown",
- description:
- "Stop the workspace browser. Use rarely — only when the user explicitly asks to close it. Cookies persist in the profile dir, so the next browser_open relaunches with the same session.",
- inputSchema: browserShutdownInput,
- handler: handleBrowserShutdown,
- },
];
diff --git a/notfair-cmo/src/server/skills/orchestration-skill.test.ts b/notfair-cmo/src/server/skills/orchestration-skill.test.ts
index 3d7c2250..5f61a322 100644
--- a/notfair-cmo/src/server/skills/orchestration-skill.test.ts
+++ b/notfair-cmo/src/server/skills/orchestration-skill.test.ts
@@ -100,12 +100,17 @@ describe("ORCHESTRATION_SKILL", () => {
"browser_press",
"browser_scroll",
"browser_back",
- "browser_shutdown",
]) {
expect(s).toContain(tool);
}
});
+ it("tells agents they CANNOT stop the workspace browser (multi-agent safety)", () => {
+ const s = getOrchestrationSkill();
+ expect(s).toMatch(/cannot stop/i);
+ expect(s).not.toContain("browser_shutdown");
+ });
+
it("teaches the snapshot → act → snapshot discipline (stale refs are the #1 browser bug)", () => {
const s = getOrchestrationSkill();
expect(s).toMatch(/snapshot AGAIN/i);
diff --git a/notfair-cmo/src/server/skills/orchestration-skill.ts b/notfair-cmo/src/server/skills/orchestration-skill.ts
index 3105f5a7..fabb7fdb 100644
--- a/notfair-cmo/src/server/skills/orchestration-skill.ts
+++ b/notfair-cmo/src/server/skills/orchestration-skill.ts
@@ -160,9 +160,11 @@ re-verification now, only the user can give it.
- \`browser_press\` — single key / chord (Tab, Escape, Control+a, ...).
- \`browser_scroll\` — viewport scroll up/down/left/right.
- \`browser_back\` — history back.
-- \`browser_shutdown\` — stop the workspace browser. Use only when the
- user explicitly asks. Cookies persist; the next \`browser_open\`
- relaunches with the same session.
+
+You CANNOT stop the workspace browser. Browser lifecycle belongs to the
+user (Settings → Workspace browser → Stop). This is deliberate: every
+agent in this workspace shares one Chrome, so stopping it would interrupt
+your teammates mid-task.
## Scheduling recurring work