Skip to content

Open-source SEO, GEO, and marketing skills for AI agents.

feat(notfair-cmo): full role label on the sidebar pill + Meta Ads color

Yuting Zhongfd97fa98538c
diff --git a/notfair-cmo/src/components/agent-nav.tsx b/notfair-cmo/src/components/agent-nav.tsx
index 1424efef..a3ea00c2 100644
--- a/notfair-cmo/src/components/agent-nav.tsx
+++ b/notfair-cmo/src/components/agent-nav.tsx
@@ -2,7 +2,14 @@
import Link from "next/link";
import { usePathname } from "next/navigation";
-import { Bot, Briefcase, Megaphone, Search, type LucideIcon } from "lucide-react";
+import {
+ Bot,
+ Briefcase,
+ Megaphone,
+ MessageCircle,
+ Search,
+ type LucideIcon,
+} from "lucide-react";
import {
SidebarMenu,
SidebarMenuButton,
@@ -44,6 +51,7 @@ type Props = {
const TEMPLATE_ICONS: Record<AgentTemplateKey, LucideIcon> = {
cmo: Briefcase,
google_ads: Megaphone,
+ meta_ads: MessageCircle,
seo: Search,
};
@@ -78,7 +86,7 @@ export function AgentNav({ projectSlug, agents, inFlightCounts = {} }: Props) {
{a.role_label && rolePalette && (
<span
className={cn(
- "ml-1 rounded-sm border px-1 py-px text-[9px] font-medium uppercase tracking-wider leading-none",
+ "ml-1 rounded-sm border px-1.5 py-[1px] text-[10px] font-medium leading-none",
rolePalette.chip,
)}
>
diff --git a/notfair-cmo/src/components/onboarding-flow.test.tsx b/notfair-cmo/src/components/onboarding-flow.test.tsx
index 7867923c..59916b0e 100644
--- a/notfair-cmo/src/components/onboarding-flow.test.tsx
+++ b/notfair-cmo/src/components/onboarding-flow.test.tsx
@@ -399,7 +399,7 @@ describe("OnboardingFlow — SetupStep", () => {
{ key: "cmo", label: "Setting up CMO", status: "in_progress" },
{
key: "google_ads",
- label: "Setting up Google Ads specialist",
+ label: "Setting up Google Ads Specialist",
status: "pending",
},
{
@@ -414,7 +414,7 @@ describe("OnboardingFlow — SetupStep", () => {
expect(
await screen.findByText(/Setting up CMO/i),
).toBeInTheDocument();
- expect(screen.getByText(/Setting up Google Ads specialist/i)).toBeInTheDocument();
+ expect(screen.getByText(/Setting up Google Ads Specialist/i)).toBeInTheDocument();
expect(screen.getByText(/Connecting agents to gateway/i)).toBeInTheDocument();
expect(routerReplace).not.toHaveBeenCalled();
});
@@ -427,7 +427,7 @@ describe("OnboardingFlow — SetupStep", () => {
{ key: "cmo", label: "Setting up CMO", status: "done" },
{
key: "google_ads",
- label: "Setting up Google Ads specialist",
+ label: "Setting up Google Ads Specialist",
status: "done",
},
{
@@ -464,7 +464,7 @@ describe("OnboardingFlow — SetupStep", () => {
},
{
key: "google_ads",
- label: "Setting up Google Ads specialist",
+ label: "Setting up Google Ads Specialist",
status: "pending",
},
{
diff --git a/notfair-cmo/src/lib/agent-colors.ts b/notfair-cmo/src/lib/agent-colors.ts
index 049da004..fd675fb5 100644
--- a/notfair-cmo/src/lib/agent-colors.ts
+++ b/notfair-cmo/src/lib/agent-colors.ts
@@ -25,6 +25,11 @@ const PALETTE: Record<AgentTemplateKey, AgentColor> = {
dot: "bg-amber-500",
label: "text-amber-700 dark:text-amber-300",
},
+ meta_ads: {
+ chip: "bg-pink-100 text-pink-900 dark:bg-pink-950 dark:text-pink-100 border-pink-200/60 dark:border-pink-900",
+ dot: "bg-pink-500",
+ label: "text-pink-700 dark:text-pink-300",
+ },
seo: {
chip: "bg-emerald-100 text-emerald-900 dark:bg-emerald-950 dark:text-emerald-100 border-emerald-200/60 dark:border-emerald-900",
dot: "bg-emerald-500",
diff --git a/notfair-cmo/src/server/agent-templates.ts b/notfair-cmo/src/server/agent-templates.ts
index 44186db5..3c51c3f8 100644
--- a/notfair-cmo/src/server/agent-templates.ts
+++ b/notfair-cmo/src/server/agent-templates.ts
@@ -205,7 +205,7 @@ ${CMO_ROLE}`,
},
{
key: "google_ads",
- display_name: "Google Ads",
+ display_name: "Google Ads Specialist",
default_name: "Ana",
description: "Runs Google Ads campaigns, keywords, bids, budgets, search terms, negatives.",
capabilities: [
@@ -235,7 +235,7 @@ for files in your workspace, and the orchestration MCP for coordination.`,
},
{
key: "meta_ads",
- display_name: "Meta Ads",
+ display_name: "Meta Ads Specialist",
default_name: "Mia",
description: "Runs Meta Ads (Facebook + Instagram) campaigns, ad sets, creative, audiences.",
capabilities: [
@@ -277,7 +277,7 @@ for files in your workspace, and the orchestration MCP for coordination.`,
},
{
key: "seo",
- display_name: "SEO",
+ display_name: "SEO Specialist",
default_name: "Sam",
description:
"Organic search — Search Console performance, technical SEO, content recommendations.",
@@ -448,7 +448,9 @@ export async function ensureProjectAgents(
// checklist instead of a single opaque spinner.
const progressSteps: ProgressStep[] = templates.map<ProgressStep>((t) => ({
key: t.key,
- label: `Setting up ${t.display_name}${t.key === "cmo" ? "" : " specialist"}`,
+ // display_name carries the full role label now (e.g. "Google Ads
+ // Specialist"), so no suffix kludge.
+ label: `Setting up ${t.display_name}`,
status: "pending",
}));
initProgress(project_slug, progressSteps);
diff --git a/notfair-cmo/src/server/onboarding/accounts.ts b/notfair-cmo/src/server/onboarding/accounts.ts
index 53fc4d45..ba874789 100644
--- a/notfair-cmo/src/server/onboarding/accounts.ts
+++ b/notfair-cmo/src/server/onboarding/accounts.ts
@@ -289,7 +289,7 @@ export async function getProvisioningProgressAction(
ok: true,
steps: [
{ key: "cmo", label: "Setting up CMO", status: "done" },
- { key: "google_ads", label: "Setting up Google Ads specialist", status: "done" },
+ { key: "google_ads", label: "Setting up Google Ads Specialist", status: "done" },
{ key: "gateway", label: "Connecting agents to gateway", status: "done" },
],
overall: "done",
diff --git a/notfair-cmo/src/server/onboarding/agent-mcp-blocker.test.ts b/notfair-cmo/src/server/onboarding/agent-mcp-blocker.test.ts
index eb74e3fd..5c74ee39 100644
--- a/notfair-cmo/src/server/onboarding/agent-mcp-blocker.test.ts
+++ b/notfair-cmo/src/server/onboarding/agent-mcp-blocker.test.ts
@@ -50,7 +50,7 @@ describe("resolveAgentMcpBlocker", () => {
expect(result).toEqual({
mcp_key: "notfair-googleads",
mcp_display_name: "NotFair Google Ads",
- agent_display_name: "Google Ads",
+ agent_display_name: "Google Ads Specialist",
});
expect(findMcpTokenMock).toHaveBeenCalledWith("acme", "notfair-googleads");
});
@@ -61,7 +61,7 @@ describe("resolveAgentMcpBlocker", () => {
expect(result).toEqual({
mcp_key: "notfair-metaads",
mcp_display_name: "NotFair Meta Ads",
- agent_display_name: "Meta Ads",
+ agent_display_name: "Meta Ads Specialist",
});
});
@@ -79,6 +79,6 @@ describe("resolveAgentMcpBlocker", () => {
getMcpCatalogMock.mockReturnValueOnce([]); // empty catalog this call
findMcpTokenMock.mockReturnValue(null);
const result = resolveAgentMcpBlocker("acme", "google_ads");
- expect(result?.mcp_display_name).toBe("Google Ads");
+ expect(result?.mcp_display_name).toBe("Google Ads Specialist");
});
});