Skip to content

A fully functional Android app built entirely with Kotlin and Jetpack Compose

remove newsResourceTitle

Keisuke Takagi072364e7f167
diff --git a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt
index 38bce838a..bebaa4711 100644
--- a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt
+++ b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt
@@ -39,7 +39,7 @@ fun AnalyticsHelper.logScreenView(screenName: String) {
)
}
-fun AnalyticsHelper.logNewsResourceOpened(newsResourceId: String, newsResourceTitle: String) {
+fun AnalyticsHelper.logNewsResourceOpened(newsResourceId: String) {
logEvent(
event = AnalyticsEvent(
type = "news_resource_opened",
diff --git a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt
index 3b0015bab..b085d27b7 100644
--- a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt
+++ b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt
@@ -67,7 +67,6 @@ fun LazyGridScope.newsFeed(
onClick = {
analyticsHelper.logNewsResourceOpened(
newsResourceId = userNewsResource.id,
- newsResourceTitle = userNewsResource.title,
)
launchCustomChromeTab(context, resourceUrl, backgroundColor)
},
diff --git a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt
index 0f6861fbc..8429dbdda 100644
--- a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt
+++ b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt
@@ -56,7 +56,6 @@ fun LazyListScope.userNewsResourceCardItems(
onClick = {
analyticsHelper.logNewsResourceOpened(
newsResourceId = userNewsResource.id,
- newsResourceTitle = userNewsResource.title,
)
when (onItemClick) {
null -> launchCustomChromeTab(context, resourceUrl, backgroundColor)