Skip to content

A fully functional Android app built entirely with Kotlin and Jetpack Compose

Move JankStats metric gathering further down

Ben Weiss42878c5e8687
diff --git a/app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt b/app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
index 20a2decb6..bedd20704 100644
--- a/app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
+++ b/app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
@@ -64,17 +64,6 @@ import com.google.samples.apps.nowinandroid.navigation.TopLevelDestination
fun NiaApp(windowSizeClass: WindowSizeClass) {
NiaTheme {
val navController = rememberNavController()
- JankMetricDisposableEffect(navController) { metricsHolder ->
- val listener = NavController.OnDestinationChangedListener { _, destination, _ ->
- metricsHolder.state?.addState("Navigation", destination.route.toString())
- }
-
- navController.addOnDestinationChangedListener(listener)
-
- onDispose {
- navController.removeOnDestinationChangedListener(listener)
- }
- }
val niaTopLevelNavigation = remember(navController) {
NiaTopLevelNavigation(navController)
@@ -124,6 +113,17 @@ fun NiaApp(windowSizeClass: WindowSizeClass) {
}
}
}
+ JankMetricDisposableEffect(navController) { metricsHolder ->
+ val listener = NavController.OnDestinationChangedListener { _, destination, _ ->
+ metricsHolder.state?.addState("Navigation", destination.route.toString())
+ }
+
+ navController.addOnDestinationChangedListener(listener)
+
+ onDispose {
+ navController.removeOnDestinationChangedListener(listener)
+ }
+ }
}
}