Skip to content

A fully functional Android app built entirely with Kotlin and Jetpack Compose

Extract scrollbar values to constants

TJ Dahunsid6a265093d75
diff --git a/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/scrollbar/Scrollbar.kt b/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/scrollbar/Scrollbar.kt
index dfe0ce1f0..3d33247d9 100644
--- a/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/scrollbar/Scrollbar.kt
+++ b/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/scrollbar/Scrollbar.kt
@@ -57,6 +57,9 @@ import kotlinx.coroutines.delay
import kotlin.math.max
import kotlin.math.min
+private const val SCROLLBAR_PRESS_DELAY = 100L
+private const val SCROLLBAR_PRESS_DELTA = 0.1f
+
/**
* Class definition for the core properties of a scroll bar
*/
@@ -310,8 +313,7 @@ fun Scrollbar(
dimension = orientation.valueOf(pressedOffset),
)
val isPositive = currentTravel < destinationTravel
- // TODO: Come up with a better heuristic for jumps
- val delta = if (isPositive) 0.1f else -0.1f
+ val delta = SCROLLBAR_PRESS_DELTA * if (isPositive) 1f else -1f
while (currentTravel != destinationTravel) {
currentTravel =
@@ -322,8 +324,7 @@ fun Scrollbar(
}
onThumbMoved(currentTravel)
interactionThumbTravelPercent = currentTravel
- // TODO: Define this more thoroughly
- delay(100)
+ delay(SCROLLBAR_PRESS_DELAY)
}
}