Skip to content

A fully functional Android app built entirely with Kotlin and Jetpack Compose

Restore `Unknown` type as empty `String`

Simon Marquisf1bc6f1226fa
diff --git a/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/NewsResourcesTestData.kt b/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/NewsResourcesTestData.kt
index 1e31c320f..ef845dc58 100644
--- a/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/NewsResourcesTestData.kt
+++ b/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/NewsResourcesTestData.kt
@@ -65,7 +65,7 @@ val newsResourcesTestData: List<NewsResource> = listOf(
url = "https://developer.android.com/jetpack/androidx/versions/all-channel",
headerImageUrl = "",
publishDate = Instant.parse("2022-10-01T00:00:00.000Z"),
- type = "Unknown",
+ type = "",
topics = listOf(topicsTestData[2]),
),
)
diff --git a/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/UserNewsResourcesTestData.kt b/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/UserNewsResourcesTestData.kt
index ab6574f6a..97acad088 100644
--- a/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/UserNewsResourcesTestData.kt
+++ b/core/testing/src/main/java/com/google/samples/apps/nowinandroid/core/testing/data/UserNewsResourcesTestData.kt
@@ -99,7 +99,7 @@ val userNewsResourcesTestData: List<UserNewsResource> = UserData(
url = "https://developer.android.com/jetpack/androidx/versions/all-channel",
headerImageUrl = "",
publishDate = Instant.parse("2022-10-01T00:00:00.000Z"),
- type = "Unknown",
+ type = "",
topics = listOf(topicsTestData[2]),
),
userData = userData,
diff --git a/core/ui/src/androidTest/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardTest.kt b/core/ui/src/androidTest/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardTest.kt
index f40bf1f33..9f5f46099 100644
--- a/core/ui/src/androidTest/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardTest.kt
+++ b/core/ui/src/androidTest/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardTest.kt
@@ -61,13 +61,13 @@ class NewsResourceCardTest {
}
@Test
- fun testMetaDataDisplay_withUnknownResource() {
- val newsWithUnknownResourceType = userNewsResourcesTestData[3]
+ fun testMetaDataDisplay_withEmptyResourceType() {
+ val newsWithEmptyResourceType = userNewsResourcesTestData[3]
var dateFormatted = ""
composeTestRule.setContent {
NewsResourceCardExpanded(
- userNewsResource = newsWithUnknownResourceType,
+ userNewsResource = newsWithEmptyResourceType,
isBookmarked = false,
hasBeenViewed = false,
onToggleBookmark = {},
@@ -75,11 +75,11 @@ class NewsResourceCardTest {
onTopicClick = {},
)
- dateFormatted = dateFormatted(publishDate = newsWithUnknownResourceType.publishDate)
+ dateFormatted = dateFormatted(publishDate = newsWithEmptyResourceType.publishDate)
}
composeTestRule
- .onNodeWithText(dateFormatted, substring = true)
+ .onNodeWithText(dateFormatted)
.assertIsDisplayed()
}