A fully functional Android app built entirely with Kotlin and Jetpack Compose
feat: replacing SubcomposeAsyncImage as its not recommended to use with lazyLayout
qamarelsafadif203e9a2185e
diff --git a/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/DynamicAsyncImage.kt b/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/DynamicAsyncImage.ktindex 7a3c39393..4a5632078 100644--- a/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/DynamicAsyncImage.kt+++ b/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/DynamicAsyncImage.kt@@ -18,19 +18,30 @@ package com.google.samples.apps.nowinandroid.core.designsystem.componentimport androidx.compose.foundation.Imageimport androidx.compose.foundation.layout.Box+import androidx.compose.foundation.layout.fillMaxWidth+import androidx.compose.foundation.layout.heightimport androidx.compose.foundation.layout.sizeimport androidx.compose.material3.CircularProgressIndicatorimport androidx.compose.material3.MaterialThemeimport androidx.compose.runtime.Composable+import androidx.compose.runtime.getValue+import androidx.compose.runtime.mutableStateOf+import androidx.compose.runtime.remember+import androidx.compose.runtime.setValueimport androidx.compose.ui.Alignmentimport androidx.compose.ui.Modifierimport androidx.compose.ui.graphics.ColorFilterimport androidx.compose.ui.graphics.painter.Painter+import androidx.compose.ui.layout.ContentScaleimport androidx.compose.ui.res.painterResourceimport androidx.compose.ui.unit.dpimport coil.compose.AsyncImage+import coil.compose.AsyncImagePainter.State.Error+import coil.compose.AsyncImagePainter.State.Loadingimport coil.compose.SubcomposeAsyncImage+import coil.compose.rememberAsyncImagePainterimport com.google.samples.apps.nowinandroid.core.designsystem.R+import com.google.samples.apps.nowinandroid.core.designsystem.R.drawableimport com.google.samples.apps.nowinandroid.core.designsystem.theme.LocalTintTheme/**@@ -44,27 +55,34 @@ fun DynamicAsyncImage(placeholder: Painter = painterResource(R.drawable.ic_placeholder_default),) {val iconTint = LocalTintTheme.current.iconTint- SubcomposeAsyncImage(- error = {- Image(- painter = placeholder,- contentDescription = "placeholder image",- )- },+ var isLoading by remember { mutableStateOf(true) }+ var isError by remember { mutableStateOf(false) }+ val imageLoader = rememberAsyncImagePainter(model = imageUrl,- contentDescription = contentDescription,- colorFilter = if (iconTint != null) ColorFilter.tint(iconTint) else null,- modifier = modifier,- loading = {- Box(- modifier = Modifier,- contentAlignment = Alignment.Center,- ) {- CircularProgressIndicator(- Modifier.size(80.dp),- color = MaterialTheme.colorScheme.tertiary,- )- }+ onState = { state ->+ isLoading = state is Loading+ isError = state is Error},)+ Box(+ modifier = modifier,+ contentAlignment = Alignment.Center,+ ) {+ if (isLoading) {+ // Display a progress bar while loading+ CircularProgressIndicator(+ modifier = Modifier+ .align(Alignment.Center)+ .size(80.dp),+ color = MaterialTheme.colorScheme.tertiary,+ )+ }+ Image(+ contentScale = ContentScale.Crop,+ painter = if (isError.not()) imageLoader else placeholder,+ contentDescription = contentDescription,+ colorFilter = if (iconTint != null) ColorFilter.tint(iconTint) else null,+ modifier = modifier,+ )+ }}diff --git a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.ktindex 621bf143c..1fb8d41e5 100644--- a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt+++ b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt@@ -44,6 +44,7 @@ import androidx.compose.runtime.DisposableEffectimport androidx.compose.runtime.getValueimport androidx.compose.runtime.mutableStateOfimport androidx.compose.runtime.remember+import androidx.compose.runtime.rememberCoroutineScopeimport androidx.compose.runtime.setValueimport androidx.compose.ui.Alignmentimport androidx.compose.ui.Modifier@@ -59,7 +60,12 @@ import androidx.compose.ui.semantics.semanticsimport androidx.compose.ui.tooling.preview.Previewimport androidx.compose.ui.tooling.preview.PreviewParameterimport androidx.compose.ui.unit.dp-import coil.compose.SubcomposeAsyncImage+import coil.compose.AsyncImage+import coil.compose.AsyncImagePainter+import coil.compose.rememberAsyncImagePainter+import coil.compose.rememberImagePainter+import coil.request.ImageRequest+import com.google.samples.apps.nowinandroid.core.designsystem.R.drawableimport com.google.samples.apps.nowinandroid.core.designsystem.component.NiaIconToggleButtonimport com.google.samples.apps.nowinandroid.core.designsystem.component.NiaTopicTagimport com.google.samples.apps.nowinandroid.core.designsystem.icon.NiaIcons@@ -74,7 +80,6 @@ import java.time.ZoneIdimport java.time.format.DateTimeFormatterimport java.time.format.FormatStyleimport java.util.Locale-import com.google.samples.apps.nowinandroid.core.designsystem.R as DesignsystemR/*** [NewsResource] card used on the following screens: For You, Saved@@ -149,32 +154,41 @@ fun NewsResourceCardExpanded(fun NewsResourceHeaderImage(headerImageUrl: String?,) {- SubcomposeAsyncImage(- modifier = Modifier- .fillMaxWidth()- .height(180.dp),- contentScale = ContentScale.Crop,+ var isLoading by remember { mutableStateOf(true) }+ var isError by remember { mutableStateOf(false) }+ val imageLoader = rememberAsyncImagePainter(model = headerImageUrl,- // TODO b/226661685: Investigate using alt text of image to populate content description- contentDescription = null, // decorative image,- error = {- Image(- painter = painterResource(DesignsystemR.drawable.ic_placeholder_default),- contentDescription = "placeholder image",- )- },- loading = {- Box(- modifier = Modifier.size(180.dp),- contentAlignment = Alignment.Center,- ) {- CircularProgressIndicator(- Modifier.size(80.dp),- color = MaterialTheme.colorScheme.tertiary,- )- }+ onState = { state ->+ isLoading = state is AsyncImagePainter.State.Loading+ isError = state is AsyncImagePainter.State.Error},)+ Box(+ modifier = Modifier+ .fillMaxWidth()+ .height(180.dp),+ contentAlignment = Alignment.Center,+ ) {+ if (isLoading) {+ // Display a progress bar while loading+ CircularProgressIndicator(+ modifier = Modifier+ .align(Alignment.Center)+ .size(80.dp),+ color = MaterialTheme.colorScheme.tertiary,+ )+ }++ Image(+ modifier = Modifier+ .fillMaxWidth()+ .height(180.dp),+ contentScale = ContentScale.Crop,+ painter = if (isError.not()) imageLoader else painterResource(drawable.ic_placeholder_default),+ // TODO b/226661685: Investigate using alt text of image to populate content description+ contentDescription = null, // decorative image,+ )+ }}@Composable@@ -249,7 +263,6 @@ fun dateFormatted(publishDate: Instant): String {.withLocale(Locale.getDefault()).withZone(zoneId).format(publishDate.toJavaInstant())-}@Composable