Skip to content

armgit / nutch

Public Imported from GitHub
0

Apache Nutch is an extensible and scalable web crawler

[NUTCH-3122] Make SpellCheckedMetadata case-insensitive for all Metadata names

Tamim Ehsan5ae91b69e4f0
diff --git a/src/java/org/apache/nutch/metadata/SpellCheckedMetadata.java b/src/java/org/apache/nutch/metadata/SpellCheckedMetadata.java
index b56f2cc1b..948a57c25 100644
--- a/src/java/org/apache/nutch/metadata/SpellCheckedMetadata.java
+++ b/src/java/org/apache/nutch/metadata/SpellCheckedMetadata.java
@@ -29,7 +29,7 @@ import org.apache.commons.lang3.StringUtils;
* {@link HttpHeaders} class.
*
*/
-public class SpellCheckedMetadata extends Metadata {
+public class SpellCheckedMetadata extends CaseInsensitiveMetadata {
/**
* Threshold divider to calculate max. Levenshtein distance for misspelled
diff --git a/src/test/org/apache/nutch/metadata/TestSpellCheckedMetadata.java b/src/test/org/apache/nutch/metadata/TestSpellCheckedMetadata.java
index 1ec52ded8..8c01f04c4 100644
--- a/src/test/org/apache/nutch/metadata/TestSpellCheckedMetadata.java
+++ b/src/test/org/apache/nutch/metadata/TestSpellCheckedMetadata.java
@@ -111,6 +111,33 @@ public class TestSpellCheckedMetadata {
Assert.assertEquals("new value 2", values[1]);
}
+ /** Test for the <code>set(String, String)</code> method. */
+ @Test
+ public void testSetCaseInsensitive() {
+ String[] values = null;
+ SpellCheckedMetadata meta = new SpellCheckedMetadata();
+
+ values = meta.getValues("name-one");
+ Assert.assertEquals(0, values.length);
+
+ meta.set("name-one", "value1");
+ values = meta.getValues("name-one");
+ Assert.assertEquals(1, values.length);
+ Assert.assertEquals("value1", values[0]);
+
+ meta.set("naMe-OnE", "value2");
+ values = meta.getValues("name-one");
+ Assert.assertEquals(1, values.length);
+ Assert.assertEquals("value2", values[0]);
+
+ meta.set("nAme-One", "new value 1");
+ meta.add("NamE-oNe", "new value 2");
+ values = meta.getValues("namE-OnE");
+ Assert.assertEquals(2, values.length);
+ Assert.assertEquals("new value 1", values[0]);
+ Assert.assertEquals("new value 2", values[1]);
+ }
+
/** Test for <code>setAll(Properties)</code> method. */
@Test
public void testSetProperties() {
@@ -151,6 +178,20 @@ public class TestSpellCheckedMetadata {
Assert.assertEquals("value-1", meta.get("a-name"));
}
+ /** Test for <code>get(String)</code> method. */
+ @Test
+ public void testGetCaseInsensitive() {
+ SpellCheckedMetadata meta = new SpellCheckedMetadata();
+ Assert.assertNull(meta.get("a-name"));
+
+ meta.add("a-name", "value-1");
+ Assert.assertEquals("value-1", meta.get("a-name"));
+
+ Assert.assertNotNull(meta.get("a-NamE"));
+ Assert.assertEquals("value-1", meta.get("a-NamE"));
+
+ }
+
/** Test for <code>isMultiValued()</code> method. */
@Test
public void testIsMultiValued() {