Skip to content

Usenet streaming with a WebDAV server and a SABnzbd-compatible API

C#

Added ui setting for health-check categories.

nzbdav-dev61eaf602f4ee
diff --git a/frontend/app/components/multi-checkbox-input/multi-checkbox-input.module.css b/frontend/app/components/multi-checkbox-input/multi-checkbox-input.module.css
index d6aa7cb6..d0b6642d 100644
--- a/frontend/app/components/multi-checkbox-input/multi-checkbox-input.module.css
+++ b/frontend/app/components/multi-checkbox-input/multi-checkbox-input.module.css
@@ -9,6 +9,15 @@
border: 1px solid var(--bs-border-color);
}
+.container :global(.form-check) {
+ min-width: calc(50% - 16px);
+}
+
+.container:not(:has(> :nth-child(4))) {
+ /* when there are 1–3 children */
+ flex-direction: column;
+}
+
.container :global(.form-check-input:not(:checked)) {
background-color: var(--bs-secondary-bg);
}
diff --git a/frontend/app/routes/settings/route.tsx b/frontend/app/routes/settings/route.tsx
index 34b295be..0d0def20 100644
--- a/frontend/app/routes/settings/route.tsx
+++ b/frontend/app/routes/settings/route.tsx
@@ -3,12 +3,12 @@ import styles from "./route.module.css"
import { Tabs, Tab, Button, Form } from "react-bootstrap"
import { backendClient } from "~/clients/backend-client.server";
import { isUsenetSettingsUpdated, UsenetSettings } from "./usenet/usenet";
-import React from "react";
import { isSabnzbdSettingsUpdated, isSabnzbdSettingsValid, SabnzbdSettings } from "./sabnzbd/sabnzbd";
import { isWebdavSettingsUpdated, isWebdavSettingsValid, WebdavSettings } from "./webdav/webdav";
import { isArrsSettingsUpdated, isArrsSettingsValid, ArrsSettings } from "./arrs/arrs";
import { Maintenance } from "./maintenance/maintenance";
import { isRepairsSettingsUpdated, RepairsSettings } from "./repairs/repairs";
+import { useCallback, useState } from "react";
const defaultConfig = {
"general.base-url": "",
@@ -16,7 +16,7 @@ const defaultConfig = {
"api.categories": "",
"api.manual-category": "uncategorized",
"api.ensure-importable-video": "true",
- "api.ensure-article-existence": "false",
+ "api.ensure-article-existence-categories": "",
"api.ignore-history-limit": "true",
"api.download-file-blocklist": "*.nfo, *.par2, *.sfv, *sample.mkv",
"api.duplicate-nzb-behavior": "increment",
@@ -61,11 +61,11 @@ type BodyProps = {
function Body(props: BodyProps) {
// stateful variables
- const [config, setConfig] = React.useState(props.config);
- const [newConfig, setNewConfig] = React.useState(config);
- const [isSaving, setIsSaving] = React.useState(false);
- const [isSaved, setIsSaved] = React.useState(false);
- const [activeTab, setActiveTab] = React.useState('usenet');
+ const [config, setConfig] = useState(props.config);
+ const [newConfig, setNewConfig] = useState(config);
+ const [isSaving, setIsSaving] = useState(false);
+ const [isSaved, setIsSaved] = useState(false);
+ const [activeTab, setActiveTab] = useState('usenet');
// derived variables
const iseUsenetUpdated = isUsenetSettingsUpdated(config, newConfig);
@@ -94,12 +94,12 @@ function Body(props: BodyProps) {
const isSaveButtonDisabled = saveButtonLabel !== "Save";
// events
- const onClear = React.useCallback(() => {
+ const onClear = useCallback(() => {
setNewConfig(config);
setIsSaved(false);
}, [config, setNewConfig]);
- const onSave = React.useCallback(async () => {
+ const onSave = useCallback(async () => {
setIsSaving(true);
setIsSaved(false);
const response = await fetch("/settings/update", {
diff --git a/frontend/app/routes/settings/sabnzbd/sabnzbd.tsx b/frontend/app/routes/settings/sabnzbd/sabnzbd.tsx
index 4b690df1..590b26f3 100644
--- a/frontend/app/routes/settings/sabnzbd/sabnzbd.tsx
+++ b/frontend/app/routes/settings/sabnzbd/sabnzbd.tsx
@@ -1,7 +1,8 @@
import { Button, Form, InputGroup } from "react-bootstrap";
-import styles from "./sabnzbd.module.css"
-import { useCallback, type Dispatch, type SetStateAction } from "react";
+import { useCallback, useEffect, useMemo, useRef, type Dispatch, type SetStateAction } from "react";
import { TagInput } from "~/components/tag-input/tag-input";
+import { MultiCheckboxInput } from "~/components/multi-checkbox-input/multi-checkbox-input";
+import styles from "./sabnzbd.module.css"
type SabnzbdSettingsProps = {
config: Record<string, string>
@@ -14,6 +15,9 @@ export function SabnzbdSettings({ config, setNewConfig }: SabnzbdSettingsProps)
setNewConfig({ ...config, "api.key": generateNewApiKey() })
}, [setNewConfig, config]);
+ const ensureArticleExistanceSetting =
+ useEnsureArticleExistanceSetting(config, setNewConfig);
+
return (
<div className={styles.container}>
<Form.Group>
@@ -176,11 +180,17 @@ export function SabnzbdSettings({ config, setNewConfig }: SabnzbdSettingsProps)
id="ensure-article-existence-checkbox"
aria-describedby="ensure-article-existence-help"
label={`Perform article health check during downloads`}
- checked={config["api.ensure-article-existence"] === "true"}
- onChange={e => setNewConfig({ ...config, "api.ensure-article-existence": "" + e.target.checked })} />
+ ref={ensureArticleExistanceSetting.masterCheckboxRef}
+ checked={!ensureArticleExistanceSetting.areNoneSelected}
+ onChange={e => ensureArticleExistanceSetting.onMasterCheckboxChange(e.target.checked)} />
<Form.Text id="ensure-article-existence-help" muted>
Whether to check for the existence of all articles within an NZB during queue processing. This process may be slow.
</Form.Text>
+ <MultiCheckboxInput
+ options={ensureArticleExistanceSetting.categories}
+ value={config["api.ensure-article-existence-categories"] ?? ""}
+ onChange={value => setNewConfig({ ...config, "api.ensure-article-existence-categories": value })}
+ />
</Form.Group>
<hr />
<Form.Group>
@@ -201,13 +211,69 @@ export function SabnzbdSettings({ config, setNewConfig }: SabnzbdSettingsProps)
);
}
+function useEnsureArticleExistanceSetting(
+ config: Record<string, string>,
+ setNewConfig: Dispatch<SetStateAction<Record<string, string>>>
+) {
+ const manualCategoryValue = config["api.manual-category"];
+ const categoriesValue = config["api.categories"];
+ const healthCheckCategoriesValue = config["api.ensure-article-existence-categories"];
+
+ const manualCategory = useMemo(() => {
+ return !!(manualCategoryValue?.trim())
+ ? manualCategoryValue.trim()
+ : "uncategorized";
+ }, [manualCategoryValue]);
+
+ const categories = useMemo(() => {
+ var list = !!(categoriesValue?.trim())
+ ? categoriesValue.split(",").map(c => c.trim()).filter(c => c.length > 0)
+ : ["audio", "software", "tv", "movies"];
+ return [manualCategory, ...list];
+ }, [categoriesValue]);
+
+ const healthCheckCategories = useMemo(() => {
+ const cats = healthCheckCategoriesValue;
+ if (!cats || cats.trim() === "") return [];
+ return cats.split(",").map(c => c.trim()).filter(c => c.length > 0);
+ }, [healthCheckCategoriesValue]);
+
+ const masterCheckboxRef = useRef<HTMLInputElement>(null);
+ const areAllSelected = categories.length > 0 && categories.every(c => healthCheckCategories.includes(c));
+ const areNoneSelected = healthCheckCategories.length === 0 || categories.every(c => !healthCheckCategories.includes(c));
+ const areSomeSelected = !areAllSelected && !areNoneSelected;
+
+ useEffect(() => {
+ if (masterCheckboxRef.current) {
+ masterCheckboxRef.current.indeterminate = areSomeSelected;
+ }
+ }, [areSomeSelected]);
+
+ const onMasterCheckboxChange = useCallback((checked: boolean) => {
+ if (checked) {
+ setNewConfig(prev => ({ ...prev, "api.ensure-article-existence-categories": categories.join(", ") }));
+ } else {
+ setNewConfig(prev => ({ ...prev, "api.ensure-article-existence-categories": "" }));
+ }
+ }, [setNewConfig, categories]);
+
+ return {
+ categories,
+ masterCheckboxRef,
+ areAllSelected,
+ areNoneSelected,
+ areSomeSelected,
+ onMasterCheckboxChange
+ }
+}
+
export function isSabnzbdSettingsUpdated(config: Record<string, string>, newConfig: Record<string, string>) {
return config["api.key"] !== newConfig["api.key"]
|| config["api.categories"] !== newConfig["api.categories"]
|| config["api.manual-category"] !== newConfig["api.manual-category"]
|| config["rclone.mount-dir"] !== newConfig["rclone.mount-dir"]
|| config["api.ensure-importable-video"] !== newConfig["api.ensure-importable-video"]
- || config["api.ensure-article-existence"] !== newConfig["api.ensure-article-existence"]
+ || config["api.ensure-article-existence-categories"] !== newConfig["api.ensure-article-existence-categories"]
|| config["api.ignore-history-limit"] !== newConfig["api.ignore-history-limit"]
|| config["api.duplicate-nzb-behavior"] !== newConfig["api.duplicate-nzb-behavior"]
|| config["api.download-file-blocklist"] !== newConfig["api.download-file-blocklist"]