Skip to content

The headless browser for AI agents and web scraping

fix(cdp): accept trailing slashes in discovery URLs (#1570)

SGavrl31e1dfed5bad
diff --git a/crates/obscura-cdp/src/server.rs b/crates/obscura-cdp/src/server.rs
index d7fefde7..fb7eb40b 100644
--- a/crates/obscura-cdp/src/server.rs
+++ b/crates/obscura-cdp/src/server.rs
@@ -1195,9 +1195,9 @@ fn accept_dispatch(
.and_then(|target| url::Url::parse(target).ok());
let path = absolute.as_ref().map(url::Url::path).or(target);
let endpoint = match path.map(|path| path.split('?').next().unwrap_or(path)) {
- Some("/json/version") => Some("version"),
- Some("/json" | "/json/list") => Some("list"),
- Some("/json/protocol") => Some("protocol"),
+ Some("/json/version" | "/json/version/") => Some("version"),
+ Some("/json" | "/json/" | "/json/list" | "/json/list/") => Some("list"),
+ Some("/json/protocol" | "/json/protocol/") => Some("protocol"),
_ => None,
};
@@ -2676,6 +2676,11 @@ mod tests {
for (target, extra, endpoint) in [
("/json/version", "", Some("Browser")),
("/json/version?client=test", "", Some("Browser")),
+ ("/json/version/", "", Some("Browser")),
+ ("/json/version/?client=test", "", Some("Browser")),
+ ("/json/list/", "", Some("webSocketDebuggerUrl")),
+ ("/json/", "", Some("webSocketDebuggerUrl")),
+ ("/json/protocol/", "", Some("version")),
("/json/list", "", Some("webSocketDebuggerUrl")),
("/json", "", Some("webSocketDebuggerUrl")),
("/json/protocol", "", Some("version")),
@@ -2683,6 +2688,9 @@ mod tests {
("/devtools/browser?next=/json/version", "", None),
("/json/versionify", "", None),
("/json/list-extra", "", None),
+ ("/json/version/extra", "", None),
+ ("/json/list/extra", "", None),
+ ("http://{authority}/json/version/?client=test", "", Some("Browser")),
("http://{authority}/json/version", "", Some("Browser")),
("http://{authority}/json/list?client=test", "", Some("webSocketDebuggerUrl")),
("http://{authority}/devtools/browser?next=/json/version", "", None),