The headless browser for AI agents and web scraping
fix(dom): escape nbsp, and < > in attribute values, when serializing
404Human8dbf7e1a55af
diff --git a/crates/obscura-dom/src/serialize.rs b/crates/obscura-dom/src/serialize.rsindex e235aa8c..8d54d9d5 100644--- a/crates/obscura-dom/src/serialize.rs+++ b/crates/obscura-dom/src/serialize.rs@@ -176,10 +176,14 @@ impl DomTree {}}+// "Escaping a string" from the HTML Standard. Attribute mode escapes `<` and+// `>` too: left literal, a value such as `</noscript><img>` ends its raw-text+// parent when the markup is parsed again.fn escape_text(s: &str, buf: &mut String) {for c in s.chars() {match c {'&' => buf.push_str("&"),+ '\u{a0}' => buf.push_str(" "),'<' => buf.push_str("<"),'>' => buf.push_str(">"),_ => buf.push(c),@@ -191,7 +195,10 @@ fn escape_attr(s: &str, buf: &mut String) {for c in s.chars() {match c {'&' => buf.push_str("&"),+ '\u{a0}' => buf.push_str(" "),'"' => buf.push_str("""),+ '<' => buf.push_str("<"),+ '>' => buf.push_str(">"),_ => buf.push(c),}}@@ -309,6 +316,36 @@ mod tests {}}+ #[test]+ fn attribute_values_and_text_are_escaped_as_the_standard_says() {+ let (out, again) = reparsed("<a title='"><img src=x> a b &amp;'>c d</a>");+ let link = "<a title=\""><img src=x> a b &amp;\">c d</a>";+ assert!(out.contains(link), "{out}");+ assert_eq!(again.outer_html(again.query_selector("a").unwrap().unwrap()), link);+ }++ #[test]+ fn an_attribute_value_cannot_end_a_raw_text_parent() {+ // What a script can build with appendChild: an element inside a+ // <noscript>, whose text the parser reads as raw text next time.+ let tree = parse_html("<noscript id=host></noscript>");+ let host = tree.get_element_by_id("host").unwrap();+ let child = tree.new_node(NodeData::Element {+ name: QualName::new(None, ns!(html), LocalName::from("p")),+ attrs: vec![crate::tree::Attribute {+ name: QualName::new(None, ns!(), LocalName::from("title")),+ value: "</noscript><img src=x onerror=1>".to_string(),+ }],+ template_contents: None,+ mathml_annotation_xml_integration_point: false,+ });+ tree.append_child(host, child);++ let out = tree.outer_html(host);+ assert_eq!(out, "<noscript id=\"host\"><p title=\"</noscript><img src=x onerror=1>\"></p></noscript>");+ assert!(parse_html(&out).query_selector("img").unwrap().is_none(), "{out}");+ }+#[test]fn test_void_elements() {let tree = parse_html(r#"<img src="test.png"><br>"#);