The headless browser for AI agents and web scraping
fix(cdp): honor canceled keydown before editing defaults
SGavrlaa4b4e7af116
diff --git a/crates/obscura-cdp/src/domains/input.rs b/crates/obscura-cdp/src/domains/input.rsindex 109384c1..59fb8fb0 100644--- a/crates/obscura-cdp/src/domains/input.rs+++ b/crates/obscura-cdp/src/domains/input.rs@@ -420,7 +420,7 @@ pub async fn handle("(function() {{\var target = document.activeElement || document.body;\var evt = globalThis.__obscura_markTrusted(new KeyboardEvent('keydown', {{bubbles:true,cancelable:true,key:{key},code:{code},keyCode:{virtual_key_code},which:{virtual_key_code},altKey:{alt_key},ctrlKey:{ctrl_key},metaKey:{meta_key},shiftKey:{shift_key}}}));\- target.dispatchEvent(evt);\+ return target.dispatchEvent(evt);\}})()",// Escape backslash BEFORE single-quote (as the text// path below does) so a key like "\" — Chrome's@@ -430,7 +430,9 @@ pub async fn handle(code = js_str(code),virtual_key_code = virtual_key_code,);- page.evaluate(&js);+ if page.evaluate(&js).as_bool() == Some(false) {+ return Ok(json!({}));+ }if !text.is_empty() && text != "\r" && text != "\n" {page.evaluate(&insert_text_js(text));diff --git a/crates/obscura-cdp/tests/textarea_enter_selection.rs b/crates/obscura-cdp/tests/textarea_enter_selection.rsindex a5c4b877..4b48bebb 100644--- a/crates/obscura-cdp/tests/textarea_enter_selection.rs+++ b/crates/obscura-cdp/tests/textarea_enter_selection.rs@@ -108,3 +108,35 @@ async fn typing_continues_after_the_inserted_newline() {assert_eq!(result["start"], 3);assert_eq!(result["end"], 3);}++#[tokio::test(flavor = "current_thread")]+async fn canceled_keydown_preserves_fields_and_delivers_keyup_without_editing_defaults() {+ let mut ctx = setup().await;+ for tag in ["input", "textarea"] {+ evaluate(&mut ctx, &format!(+ "document.body.innerHTML = '<{tag} id=field></{tag}>'; field.focus();\+ field.addEventListener('keydown', event => event.preventDefault());\+ for (const type of ['keydown', 'keypress', 'beforeinput', 'input', 'keyup'])\+ field.addEventListener(type, event => changes.push(event.type));"+ )).await;+ for event_type in ["keyDown", "rawKeyDown"] {+ for (key, text, virtual_key) in [+ ("Z", "Z", 90), ("Backspace", "", 8),+ ("Delete", "", 46), ("Enter", "\r", 13),+ ] {+ evaluate(&mut ctx, "field.value = 'abCD'; field.setSelectionRange(1, 3); changes.length = 0;").await;+ cdp(&mut ctx, "Input.dispatchKeyEvent", json!({+ "type": event_type, "key": key, "text": text,+ "windowsVirtualKeyCode": virtual_key,+ })).await;+ cdp(&mut ctx, "Input.dispatchKeyEvent", json!({+ "type": "keyUp", "key": key, "windowsVirtualKeyCode": virtual_key,+ })).await;+ assert_eq!(state(&mut ctx).await, json!({+ "value": "abCD", "start": 1, "end": 3,+ "changes": ["keydown", "keyup"],+ }), "{tag} {event_type} {key}");+ }+ }+ }+}