Self-hosted AI workspace.
Python
fix(tests): resolve temp paths consistently on macOS
Léo32d9dbc267eb
diff --git a/tests/KNOWN_FAILURES.md b/tests/KNOWN_FAILURES.mdindex 414c82059..4af06c7dc 100644--- a/tests/KNOWN_FAILURES.md+++ b/tests/KNOWN_FAILURES.md@@ -9,10 +9,10 @@ This is that list. It is a record of observation, not a permission slip: a testhere is still a test that does not pass, and three of the six below aredefects someone should fix.-Last measured: `lab @ c499c01b`, macOS 15 on Apple Silicon, Python 3.11.+Last measured: `lab @ c499c01b` plus the fixes in this change, macOS 15 on Apple Silicon, Python 3.11.```-6 failed, 10658 passed, 6 skipped+3 failed, 10658 passed, 6 skipped```## Get the prerequisites right first@@ -38,26 +38,24 @@ including one holding real data.Miss `npm ci` and roughly 36 browser tests fail on `Cannot find package'playwright'`. That is not a regression, it is the missing install.-## The six+## The three-### Test bugs: comparing an unresolved path against a resolved one+### Test bugs: fixed-- `tests/test_code_nav_tools.py::test_read_file_extracts_structured_documents`-- `tests/test_code_nav_tools.py::test_read_file_extracts_legacy_word_documents`-- `tests/test_workspace_confine.py::test_glob_confined_e2e`+Three failures compared an unresolved `/tmp` path against a resolved+`/private/tmp` one, and are fixed rather than listed:-```-assert [('/private/tmp/codenav_.../report.docx', ...)]- == [('/tmp/codenav_.../report.docx', ...)]-```--On macOS `/tmp` is a symlink to `/private/tmp`. The code under test resolves-the path and the assertion does not, so the two disagree about a file they both-found. Nothing is wrong with the behaviour.+- `tests/test_code_nav_tools.py` (two tests) built a fixture under+ `tempfile.mkdtemp(dir="/tmp")` and compared it against the path the code+ reports, which it resolves.+- `tests/test_workspace_confine.py::test_glob_confined_e2e` mixed+ `os.path.realpath(ws)` with an unresolved secret directory, so `relpath`+ produced `../../../../tmp/<absolute path>` and the assertion that the+ absolute path was absent matched it as a substring.-**These are fixable and should be fixed**: resolve both sides before comparing.-They are listed as known rather than environmental because the platform is only-what exposes them.+Both now resolve consistently. They are recorded here because the shape recurs:+on macOS, mixing a resolved and an unresolved temp path is a test bug that+looks like a platform failure.### Optional dependency: ffmpeg without a WebP encoderdiff --git a/tests/test_code_nav_tools.py b/tests/test_code_nav_tools.pyindex 2c472be9f..33fd4c8d8 100644--- a/tests/test_code_nav_tools.py+++ b/tests/test_code_nav_tools.py@@ -17,7 +17,10 @@ def _run(tool, content):@pytest.fixturedef repo():# Built under /tmp, which is on the default tool-path allowlist.- root = tempfile.mkdtemp(dir="/tmp", prefix="codenav_")+ # realpath because the code under test resolves the path it reports, and on+ # macOS /tmp is a symlink to /private/tmp: comparing the unresolved path+ # against the resolved one fails on a file both sides found correctly.+ root = os.path.realpath(tempfile.mkdtemp(dir="/tmp", prefix="codenav_"))try:with open(os.path.join(root, "a.py"), "w") as f:f.write("import os\n# needle here\nprint('x')\n")diff --git a/tests/test_workspace_confine.py b/tests/test_workspace_confine.pyindex 3d746d7d2..25ca7c192 100644--- a/tests/test_workspace_confine.py+++ b/tests/test_workspace_confine.py@@ -225,8 +225,13 @@ async def test_glob_confined_e2e(ws, admin):assert ws not in r["output"]assert "/workspace/found.py" in r["output"]- # a secret outside the workspace must not be discoverable via glob- outside = tempfile.mkdtemp()+ # a secret outside the workspace must not be discoverable via glob.+ # realpath so this directory and os.path.realpath(ws) below sit in the same+ # resolved tree. On macOS /tmp is a symlink to /private/tmp, and mixing a+ # resolved workspace with an unresolved secret makes relpath emit+ # "../../../../tmp/<abs path>", which trivially contains the absolute path+ # the assertion is checking for.+ outside = os.path.realpath(tempfile.mkdtemp())secret = os.path.join(outside, "secret.txt")with open(secret, "w") as f:f.write("nope")