Skip to content

Get up and running with Kimi, GLM, MiniMax, DeepSeek, gpt-oss, Qwen, Gemma and other models.

tui: avoid table detection for pipe prose (#17424)

Parth Sareenbf7be180e306
diff --git a/cmd/tui/chat/markdown.go b/cmd/tui/chat/markdown.go
index 00accac07..49dec98d6 100644
--- a/cmd/tui/chat/markdown.go
+++ b/cmd/tui/chat/markdown.go
@@ -387,8 +387,10 @@ func isMarkdownTableSeparator(line string) bool {
return false
}
for _, cell := range cells {
- cell = strings.Trim(cell, " :-")
- if cell != "" {
+ cell = strings.TrimSpace(cell)
+ cell = strings.TrimPrefix(cell, ":")
+ cell = strings.TrimSuffix(cell, ":")
+ if cell == "" || strings.Trim(cell, "-") != "" {
return false
}
}
diff --git a/cmd/tui/chat/render_test.go b/cmd/tui/chat/render_test.go
index 5b7ef72d4..d6a103737 100644
--- a/cmd/tui/chat/render_test.go
+++ b/cmd/tui/chat/render_test.go
@@ -2075,3 +2075,39 @@ func TestRenderMarkdownTableWrapsLongCells(t *testing.T) {
}
}
}
+
+func TestRenderMarkdownProseWithPipeExamplesIsNotTable(t *testing.T) {
+ markdown := strings.Join([]string{
+ "- **Regression confirmed** vs. `fdbe8d33`: the bare `< | open | >` remains prose.",
+ "| | |",
+ "- **Severity**: `< | close | >` is another inline example.",
+ }, "\n")
+
+ rendered := renderMarkdownForView(markdown, 120)
+ plain := stripANSI(rendered)
+ if !strings.Contains(plain, "| | |") || !strings.Contains(plain, "the bare < | open | > remains") || !strings.Contains(plain, "< | close | > is another") {
+ t.Fatalf("pipe-delimited prose rendered as a table:\n%s", plain)
+ }
+ if !strings.Contains(rendered, chatStrongStyle.Render("Regression confirmed")) {
+ t.Fatalf("bold prose was not emphasized: %q", rendered)
+ }
+ if !strings.Contains(rendered, chatInlineCodeStyle.Render("fdbe8d33")) {
+ t.Fatalf("inline code was not styled: %q", rendered)
+ }
+}
+
+func TestRenderMarkdownTablePreservesValidSeparator(t *testing.T) {
+ markdown := strings.Join([]string{
+ "| Name | State |",
+ "| --- | :---: |",
+ "| Ollama | Ready |",
+ }, "\n")
+
+ plain := stripANSI(renderMarkdownForView(markdown, 80))
+ if strings.Contains(plain, "---") {
+ t.Fatalf("table separator should not render as prose:\n%s", plain)
+ }
+ if !strings.Contains(plain, "Name") || !strings.Contains(plain, "Ollama") {
+ t.Fatalf("valid Markdown table was not rendered:\n%s", plain)
+ }
+}