A desktop coding agent with free access to frontier models.
TypeScript
fix(app): a failed request to the built-in server no longer blanks the task list
ogsamrat2165cedd7bd0
diff --git a/apps/app/src/app/lib/opencode-session-native.ts b/apps/app/src/app/lib/opencode-session-native.tsindex 747b45fb..ae4c19ae 100644--- a/apps/app/src/app/lib/opencode-session-native.ts+++ b/apps/app/src/app/lib/opencode-session-native.ts@@ -78,10 +78,11 @@ function unwrapSessionResult<T>(result: FieldsResult<T>, notFoundCode?: string):return unwrap(result);} catch (error) {if (error instanceof Error) {- Object.assign(error, { status: result.response.status });+ const status = result.response?.status;+ if (typeof status === "number") Object.assign(error, { status });const code = result.error && typeof result.error === "object" && "code" in result.error && typeof result.error.code === "string"? result.error.code- : result.response.status === 404+ : status === 404? notFoundCode: undefined;if (code) Object.assign(error, { code });diff --git a/apps/app/src/app/lib/opencode-v2-adapter.ts b/apps/app/src/app/lib/opencode-v2-adapter.tsindex 66de161d..7dcf9520 100644--- a/apps/app/src/app/lib/opencode-v2-adapter.ts+++ b/apps/app/src/app/lib/opencode-v2-adapter.ts@@ -1421,7 +1421,8 @@ export function createClientV2(if (result.error !== undefined) {return { error: result.error, request: result.request, response: result.response };}- return { data: true, request: result.request, response: result.response };+ // No error means fetch completed, so the response is present.+ return { data: true, request: result.request, response: result.response as Response };};const respondPermission = async (@@ -1436,7 +1437,8 @@ export function createClientV2(if (result.error !== undefined) {return { error: result.error, request: result.request, response: result.response };}- return { data: true, request: result.request, response: result.response };+ // No error means fetch completed, so the response is present.+ return { data: true, request: result.request, response: result.response as Response };};const listQuestions = async (diff --git a/apps/app/src/app/lib/opencode.ts b/apps/app/src/app/lib/opencode.tsindex 83fc1a08..9b33b8e1 100644--- a/apps/app/src/app/lib/opencode.ts+++ b/apps/app/src/app/lib/opencode.ts@@ -5,7 +5,9 @@ import { isDesktopRuntime } from "./runtime-env";export type FieldsResult<T> =| ({ data: T; error?: undefined } & { request: Request; response: Response })- | ({ data?: undefined; error: unknown } & { request: Request; response: Response });+ // `response` is missing when fetch itself rejected (server not listening, or+ // the request timed out), so every error-path reader must tolerate it.+ | ({ data?: undefined; error: unknown } & { request: Request; response?: Response });type PromptAsyncParameters = {sessionID: string;diff --git a/apps/app/src/react-app/shell/route-workspaces.ts b/apps/app/src/react-app/shell/route-workspaces.tsindex 6c840fa0..15587e25 100644--- a/apps/app/src/react-app/shell/route-workspaces.ts+++ b/apps/app/src/react-app/shell/route-workspaces.ts@@ -88,7 +88,8 @@ export async function listRouteSessions(return unwrap(result);} catch (error) {if (error instanceof Error) {- Object.assign(error, { status: result.response.status });+ const status = result.response?.status;+ if (typeof status === "number") Object.assign(error, { status });if (result.error && typeof result.error === "object" && "code" in result.error && typeof result.error.code === "string") {Object.assign(error, { code: result.error.code });}diff --git a/apps/app/src/react-app/shell/use-workspace-route-state.ts b/apps/app/src/react-app/shell/use-workspace-route-state.tsindex 4da2c6f9..624424da 100644--- a/apps/app/src/react-app/shell/use-workspace-route-state.ts+++ b/apps/app/src/react-app/shell/use-workspace-route-state.ts@@ -104,6 +104,10 @@ type ModernRouteSessionResolution =* which the session pane renders as an indefinite loading state. */const ROUTE_REFRESH_STEP_TIMEOUT_MS = 15_000;const ROUTE_WORKSPACE_ACTIVATION_SETTLE_MS = 750;+// Slow retry rounds for a local task list that keeps failing (engine still+// starting or restarting): 20 rounds of 15 s cover about five minutes.+const LOCAL_LIST_RETRY_ROUNDS = 20;+const LOCAL_LIST_RETRY_ROUND_DELAY_MS = 15_000;function withRouteRefreshTimeout<T>(promise: Promise<T>, label: string): Promise<T> {return new Promise<T>((resolve, reject) => {@@ -244,6 +248,7 @@ export function useWorkspaceRouteState(input: UseWorkspaceRouteStateInput) {const hydratedRouteSessionIdsRef = useRef<Record<string, string>>({});const startupRetryTimerRef = useRef<number | null>(null);const [retryingWorkspaceIds, setRetryingWorkspaceIds] = useState<string[]>([]);+ const localListRetryRoundsRef = useRef(new Map<string, number>());const reconnectAttemptedWorkspaceIdRef = useRef("");const backgroundSessionLoadCoalescerRef = useRef(createRouteWorkspaceLoadCoalescer());const loadedWorkspaceIdsRef = useRef(new Set<string>());@@ -368,6 +373,7 @@ export function useWorkspaceRouteState(input: UseWorkspaceRouteStateInput) {sessionsByWorkspaceIdRef.current = next;setSessionsByWorkspaceId(next);loadedWorkspaceIdsRef.current.add(workspace.id);+ localListRetryRoundsRef.current.delete(workspace.id);setErrorsByWorkspaceId((current) => ({ ...current, [workspace.id]: null }));setWorkspaceConnectionOverrides((current) => {if (isRemoteOmniRushWorkspace) {@@ -418,6 +424,25 @@ export function useWorkspaceRouteState(input: UseWorkspaceRouteStateInput) {}// Final failure: keep local workspace startup quiet, but give// remote workers a precise endpoint/token/workspace diagnostic.+ if (workspace.workspaceType !== "remote") {+ // A local engine that is still starting (or restarting) must not+ // leave the group as an empty "No tasks yet": keep it loading and+ // try again in slower rounds, then show the error if it persists.+ const rounds = (localListRetryRoundsRef.current.get(workspace.id) ?? 0) + 1;+ localListRetryRoundsRef.current.set(workspace.id, rounds);+ if (classifyRouteSessionReadError(error) === "retryable" && rounds < LOCAL_LIST_RETRY_ROUNDS) {+ window.setTimeout(() => {+ if (backgroundSessionLoadCoalescerRef.current.isInFlight(workspace.id)) return;+ void backgroundSessionLoadCoalescerRef.current.run(+ workspace.id,+ () => fetchWithRetries(workspace, 0),+ );+ }, LOCAL_LIST_RETRY_ROUND_DELAY_MS);+ return;+ }+ localListRetryRoundsRef.current.delete(workspace.id);+ setErrorsByWorkspaceId((current) => ({ ...current, [workspace.id]: message }));+ }if (workspace.workspaceType === "remote") {const connectionState = await diagnoseRemoteWorkspaceTaskLoadFailure(workspace, message);setErrorsByWorkspaceId((current) => ({diff --git a/apps/app/tests/opencode-session-native.test.ts b/apps/app/tests/opencode-session-native.test.tsindex 094c605e..3d22039f 100644--- a/apps/app/tests/opencode-session-native.test.ts+++ b/apps/app/tests/opencode-session-native.test.ts@@ -13,6 +13,7 @@ import {getNativeSessionMessages,type NativeSessionOperations,} from "../src/app/lib/opencode-session-native";+import { classifyRouteSessionReadError } from "../src/react-app/shell/route-workspaces";const endpoint = {opencodeBaseUrl: "https://worker.example/workspace/ws-native/opencode",@@ -199,6 +200,25 @@ describe("native OpenCode session operations", () => {}});+ test("a request with no response keeps its own error and stays retryable", async () => {+ for (const cause of [new TypeError("Failed to fetch"), new Error("Request timed out.")]) {+ const promise = getNativeSession(endpoint, "ses_native", undefined, {+ createOperations: () => operations({+ get: async () => ({ error: cause, request: new Request(endpoint.opencodeBaseUrl), response: undefined }),+ }),+ });+ try {+ await promise;+ throw new Error("Expected native session read to fail");+ } catch (error) {+ expect(error).toBeInstanceOf(Error);+ expect((error as Error).message).toBe(cause.message);+ expect(error).not.toHaveProperty("status");+ expect(classifyRouteSessionReadError(error)).toBe("retryable");+ }+ }+ });+test("fails the snapshot when any native operation fails", async () => {await expect(composeNativeSessionSnapshot(endpoint, session.id, undefined, {createOperations: () => operations({diff --git a/apps/app/tests/route-session-list.test.ts b/apps/app/tests/route-session-list.test.tsindex d69ca292..ed538e3d 100644--- a/apps/app/tests/route-session-list.test.ts+++ b/apps/app/tests/route-session-list.test.ts@@ -1,7 +1,7 @@import { describe, expect, test } from "bun:test";import { resolveWorkspaceEndpoint } from "../src/app/lib/workspace-endpoint";-import { listRouteSessions, readRouteSessionsWithRetry } from "../src/react-app/shell/route-workspaces";+import { classifyRouteSessionReadError, listRouteSessions, readRouteSessionsWithRetry } from "../src/react-app/shell/route-workspaces";describe("workspace route native session lists", () => {test("loads a bare session array through the local native transport input", async () => {@@ -31,6 +31,31 @@ describe("workspace route native session lists", () => {expect(endpoint.token).toBe("local-token");});+ test("a list request with no response (server down or timed out) stays retryable", async () => {+ const endpoint = resolveWorkspaceEndpoint({+ id: "local workspace",+ workspaceType: "local",+ }, {+ baseUrl: "https://local.example.test",+ token: "local-token",+ });+ if (!endpoint) throw new Error("Expected a local endpoint");++ for (const cause of [new TypeError("Failed to fetch"), new Error("Request timed out.")]) {+ try {+ await listRouteSessions(endpoint, async () => ({+ error: cause,+ request: new Request(`${endpoint.opencodeBaseUrl}/session?limit=200`),+ response: undefined,+ }));+ throw new Error("Expected the list to fail");+ } catch (error) {+ expect((error as Error).message).toBe(cause.message);+ expect(classifyRouteSessionReadError(error)).toBe("retryable");+ }+ }+ });+test("retries a remote native list failure on the remote endpoint and token", async () => {const endpoint = resolveWorkspaceEndpoint({id: "rem_ui-id",