Skip to content

A desktop coding agent with free access to frontier models.

TypeScript

fix: quality status inside the chip

ogsamrat3628b1dff4fc
diff --git a/apps/app/src/react-app/domains/quality/good-session.tsx b/apps/app/src/react-app/domains/quality/good-session.tsx
index c846de8f..877a5418 100644
--- a/apps/app/src/react-app/domains/quality/good-session.tsx
+++ b/apps/app/src/react-app/domains/quality/good-session.tsx
@@ -265,7 +265,7 @@ function useGoodSession(
export function GoodSessionLine({ result }: { result: OmniRushGoodSession | null }) {
const copy = goodSessionCopy(result);
return (
- <p role="status" data-testid="good-session-confirmed" data-state={copy.state} className="mx-auto max-w-[800px] pb-1 text-[11px] leading-4">
+ <p role="status" data-testid="good-session-confirmed" data-state={copy.state} className="text-[11px] leading-4">
{copy.state === "good" ? (
<span className="font-medium text-foreground">{copy.text}</span>
) : copy.state === "pending" ? (
@@ -470,6 +470,13 @@ export function GoodSessionChecklistBar(props: GoodSessionChecklistBarProps) {
if (!hasPrompt) return null;
const verdict = checklist.verdict;
const passedChecks = checklist.checks.filter((check) => check.state === "pass").length;
+ const hasStatus = Boolean(checklist.message || checklist.reasons.length || checklist.delivery);
+ const statusLines = [
+ ...(checklist.message ? [checklist.message] : []),
+ ...checklist.reasons,
+ ...(checklist.delivery ? [checklist.delivery] : []),
+ ...(props.client ? [goodSessionCopy(goodSession).text] : []),
+ ];
const dock = checklist.dock;
const dockLink = dock?.link;
return (
@@ -496,15 +503,6 @@ export function GoodSessionChecklistBar(props: GoodSessionChecklistBarProps) {
) : null}
</div>
) : null}
- {checklist.message || checklist.reasons.length || checklist.delivery ? (
- <div className="mx-auto max-w-[800px] pb-1 text-[11px] leading-4 text-muted-foreground" data-testid="good-session-server-message">
- {checklist.message ? (
- <p className={cn("font-medium", checklist.messageTone ? TONE_TEXT[checklist.messageTone] : "text-foreground")}>{checklist.message}</p>
- ) : null}
- {checklist.reasons.map((reason) => <p key={reason} className="text-amber-11">{reason}</p>)}
- {checklist.delivery ? <p data-testid="good-session-delivery">{checklist.delivery}</p> : null}
- </div>
- ) : null}
{followUpShown ? (
<div className="mx-auto flex max-w-[800px] items-center gap-2 pb-1 text-[11px] leading-4 text-muted-foreground" data-testid="good-session-follow-up" role="status">
<span className="min-w-0 flex-1">{FOLLOW_UP_HINT}</span>
@@ -521,7 +519,6 @@ export function GoodSessionChecklistBar(props: GoodSessionChecklistBarProps) {
</button>
</div>
) : null}
- {props.client ? <GoodSessionLine result={goodSession} /> : null}
{/* At every width: a compact summary ("On track ★ 4/6") that opens to the full checklist,
and the guide link on its own line under it (never cut off at the right edge). */}
<div className="mx-auto flex max-w-[800px] flex-col items-start gap-1 pb-1.5" data-testid="good-session-row" data-expanded={checklistOpen ? "" : undefined}>
@@ -534,7 +531,8 @@ export function GoodSessionChecklistBar(props: GoodSessionChecklistBarProps) {
writePref(CHECKLIST_OPEN_KEY, next ? "1" : "0");
}}
aria-expanded={checklistOpen}
- aria-label={checklist.text}
+ aria-label={[checklist.text, ...statusLines].join(". ")}
+ title={statusLines.join("\n") || undefined}
data-testid="good-session-summary"
className={cn(
"flex max-w-full min-w-0 flex-wrap items-center gap-x-1.5 gap-y-1 border border-border bg-popover/60 px-2.5 py-1 text-start text-[11px] leading-4 text-muted-foreground transition-colors hover:bg-muted/60",
@@ -560,6 +558,18 @@ export function GoodSessionChecklistBar(props: GoodSessionChecklistBarProps) {
</span>
) : null}
</button>
+ {/* The status (server message, reasons, delivery, the integrity verdict) lives here and in the
+ chip's tooltip, never as extra lines over the chat. */}
+ {checklistOpen && (hasStatus || props.client) ? (
+ <div className="w-full px-3 text-[11px] leading-4 text-muted-foreground" data-testid="good-session-server-message">
+ {checklist.message ? (
+ <p className={cn("font-medium", checklist.messageTone ? TONE_TEXT[checklist.messageTone] : "text-foreground")}>{checklist.message}</p>
+ ) : null}
+ {checklist.reasons.map((reason) => <p key={reason} className="text-amber-11">{reason}</p>)}
+ {checklist.delivery ? <p data-testid="good-session-delivery">{checklist.delivery}</p> : null}
+ {props.client ? <GoodSessionLine result={goodSession} /> : null}
+ </div>
+ ) : null}
<Popover>
<PopoverTrigger
render={(