Skip to content

A desktop coding agent with free access to frontier models.

TypeScript

fix: share the initial provider discovery baseline

Task Builder93a45b9305fb
diff --git a/apps/app/src/app/lib/provider-events.ts b/apps/app/src/app/lib/provider-events.ts
index ae8ec310..f990a4fc 100644
--- a/apps/app/src/app/lib/provider-events.ts
+++ b/apps/app/src/app/lib/provider-events.ts
@@ -31,3 +31,22 @@ export function dispatchNewProviders(detail: NewProvidersEventDetail): void {
new CustomEvent<NewProvidersEventDetail>(newProvidersEvent, { detail }),
);
}
+
+const SEEN_KEY = "omnirush.seenProviderIds";
+
+export function readSeenProviderIds(): Set<string> {
+ try {
+ const raw = window.localStorage.getItem(SEEN_KEY);
+ return new Set(raw ? JSON.parse(raw) : []);
+ } catch {
+ return new Set();
+ }
+}
+
+export function markProvidersSeen(ids: string[]): void {
+ try {
+ const existing = readSeenProviderIds();
+ for (const id of ids) existing.add(id);
+ window.localStorage.setItem(SEEN_KEY, JSON.stringify([...existing]));
+ } catch {}
+}
diff --git a/apps/app/src/react-app/infra/provider-list-query.ts b/apps/app/src/react-app/infra/provider-list-query.ts
index fe825006..9747065e 100644
--- a/apps/app/src/react-app/infra/provider-list-query.ts
+++ b/apps/app/src/react-app/infra/provider-list-query.ts
@@ -2,7 +2,7 @@ import { useQuery, type QueryClient } from "@tanstack/react-query";
import type { Client, ModelRef, ProviderListItem } from "../../app/types";
import { unwrap } from "../../app/lib/opencode";
-import { dispatchNewProviders } from "../../app/lib/provider-events";
+import { dispatchNewProviders, markProvidersSeen } from "../../app/lib/provider-events";
import type { ProviderListResponse } from "@opencode-ai/sdk/v2/client";
import { resolveModelDisplayName } from "../../app/utils";
@@ -157,6 +157,9 @@ function dispatchConnectedProviderChanges(
key,
new Map(next.map((provider) => [provider.id, new Set(Object.keys(provider.models))])),
);
+ // Other sync sources also use this baseline to avoid announcing a
+ // returning provider that never needed an initial notification.
+ markProvidersSeen(next.map((provider) => provider.id));
}
return;
}
diff --git a/apps/app/src/react-app/shell/new-providers-listener.tsx b/apps/app/src/react-app/shell/new-providers-listener.tsx
index 6ca48e83..4b97d1f5 100644
--- a/apps/app/src/react-app/shell/new-providers-listener.tsx
+++ b/apps/app/src/react-app/shell/new-providers-listener.tsx
@@ -3,6 +3,8 @@ import { useCallback, useEffect, useState } from "react";
import { resolveProviderDisplayName } from "@/app/utils";
import {
newProvidersEvent,
+ readSeenProviderIds,
+ markProvidersSeen,
type NewProviderInfo,
type NewProvidersEventDetail,
} from "@/app/lib/provider-events";
@@ -11,7 +13,6 @@ import { useNotificationStore } from "@/react-app/kernel/notification-store";
import { notifyEvent } from "./notifications";
import { orgOnboardingVisibilityEvent } from "./reload-coordinator";
-const SEEN_KEY = "omnirush.seenProviderIds";
const PENDING_MODEL_PICKER_KEY = "omnirush.pendingModelPickerProviderIds";
const NEW_PROVIDERS_DEDUPE_KEY = "new-providers";
@@ -21,22 +22,6 @@ export const openModelPickerEvent = "omnirush-open-model-picker";
export const openProviderAuthEvent = "omnirush-open-provider-auth";
export const pendingModelPickerProviderIdsKey = PENDING_MODEL_PICKER_KEY;
-function readSeenProviderIds(): Set<string> {
- try {
- const raw = window.localStorage.getItem(SEEN_KEY);
- return new Set(raw ? JSON.parse(raw) : []);
- } catch {
- return new Set();
- }
-}
-
-function markProvidersSeen(ids: string[]): void {
- try {
- const existing = readSeenProviderIds();
- for (const id of ids) existing.add(id);
- window.localStorage.setItem(SEEN_KEY, JSON.stringify([...existing]));
- } catch {}
-}
/**
* Open the model picker focused on the given new providers. If no session
diff --git a/apps/app/tests/renderer-bounded-caches.test.ts b/apps/app/tests/renderer-bounded-caches.test.ts
index 5d9b36c6..da3649de 100644
--- a/apps/app/tests/renderer-bounded-caches.test.ts
+++ b/apps/app/tests/renderer-bounded-caches.test.ts
@@ -4,7 +4,7 @@ import type { ProviderListResponse } from "@opencode-ai/sdk/v2/client";
import type { Client, ProviderListItem } from "../src/app/types";
import { createClient } from "../src/app/lib/opencode";
-import { newProvidersEvent, type NewProvidersEventDetail } from "../src/app/lib/provider-events";
+import { newProvidersEvent, readSeenProviderIds, type NewProvidersEventDetail } from "../src/app/lib/provider-events";
import {
clearProviderListQueries,
fetchProviderList,
@@ -82,6 +82,13 @@ beforeEach(() => {
clearProviderListQueries(new QueryClient());
discoveries = [];
const events = new EventTarget();
+ const storage = new Map<string, string>();
+ Object.defineProperty(events, "localStorage", {
+ value: {
+ getItem: (key: string) => storage.get(key) ?? null,
+ setItem: (key: string, value: string) => { storage.set(key, value); },
+ },
+ });
events.addEventListener(newProvidersEvent, (event) => {
if (event instanceof CustomEvent) discoveries.push(event.detail);
});
@@ -129,6 +136,7 @@ test("provider discovery stays quiet through startup, metadata refreshes, and re
try {
await refresh([]);
await refresh(baseline);
+ expect(readSeenProviderIds().has("catalog-provider")).toBe(true);
await refresh(baseline, 1);
expect(discoveries).toHaveLength(0);
diff --git a/evals/specs/provider-catalog-notifications.e2e.test.ts b/evals/specs/provider-catalog-notifications.e2e.test.ts
index 8265fb07..9d626efa 100644
--- a/evals/specs/provider-catalog-notifications.e2e.test.ts
+++ b/evals/specs/provider-catalog-notifications.e2e.test.ts
@@ -30,8 +30,8 @@ test("catalog refreshes announce new models once and keep metadata updates and r
within: 60_000, label: "updated model metadata visible", until: (value) => value === true,
});
const entries = await notifications();
- expect(entries).toHaveLength(0);
evidence.recordAssertionEvidence("Metadata updates do not announce existing models", "The picker shows revision 1; notifications=" + JSON.stringify(entries), entries.length === 0);
+ expect(entries).toHaveLength(0);
await user.press("Escape");
});
@@ -46,8 +46,8 @@ test("catalog refreshes announce new models once and keep metadata updates and r
within: 60_000, label: "provider reconnected", until: (value) => value === true,
});
const entries = await notifications();
- expect(entries).toHaveLength(0);
evidence.recordAssertionEvidence("Reconnecting does not announce the same provider and models", "The existing model disappeared and returned; notifications=" + JSON.stringify(entries), entries.length === 0);
+ expect(entries).toHaveLength(0);
await user.press("Escape");
});