Skip to content

A desktop coding agent with free access to frontier models.

TypeScript

fix: advanced settings no longer show a panel the app cannot fill

ogsamratba4e1d3f1d89
diff --git a/apps/app/src/react-app/shell/settings-route.tsx b/apps/app/src/react-app/shell/settings-route.tsx
index df1084dc..892cb1bc 100644
--- a/apps/app/src/react-app/shell/settings-route.tsx
+++ b/apps/app/src/react-app/shell/settings-route.tsx
@@ -91,7 +91,6 @@ import type { BestPracticesClient } from "@/react-app/domains/settings/best-prac
import type { AgentAssistClient } from "@/react-app/domains/settings/agent-assist";
import { AuthorizedFoldersPanel } from "@/react-app/domains/settings/panels/authorized-folders-panel";
import { BrowserLoginsPanel } from "../domains/browser-logins/browser-logins-panel";
-import { EffectivePermissionsPanel } from "@/react-app/domains/settings/panels/effective-permissions-panel";
import { SettingsStack } from "@/react-app/domains/settings/settings-section";
import { AdvancedView } from "@/react-app/domains/settings/pages/advanced-view";
import { AppearanceView } from "@/react-app/domains/settings/pages/appearance-view";
@@ -552,7 +551,6 @@ function SettingsRouteContent(props: SettingsSurfaceProps = {}) {
const [themeMode, setThemeModeState] = useState<ThemeMode>(getInitialThemeMode);
const [hideTitlebar, setHideTitlebar] = useState(() => readStoredBoolean(SETTINGS_HIDE_TITLEBAR_KEY, false));
const [configActionStatus, setConfigActionStatus] = useState<string | null>(null);
- const [permissionsRefreshToken, setPermissionsRefreshToken] = useState(0);
const [revealConfigBusy, setRevealConfigBusy] = useState(false);
const [resetConfigBusy, setResetConfigBusy] = useState(false);
const [renameWorkspaceId, setRenameWorkspaceId] = useState<string | null>(null);
@@ -2320,7 +2318,6 @@ function SettingsRouteContent(props: SettingsSurfaceProps = {}) {
activeWorkspaceType={workspaceType}
onConfigUpdated={() => {
setConfigActionStatus(t("settings.config_updated"));
- setPermissionsRefreshToken((token) => token + 1);
void providerAuthStore.refreshProviders();
void connectionsStore.refreshMcpServers();
}}
@@ -2560,13 +2557,6 @@ function SettingsRouteContent(props: SettingsSurfaceProps = {}) {
onCleanupOmniRushDockerContainers={() => {}}
/>
) : null}
- <EffectivePermissionsPanel
- omnirushServerClient={omnirushClient}
- omnirushServerStatus={routeOmniRushStatus}
- omnirushServerCapabilities={routeOmniRushCapabilities}
- runtimeWorkspaceId={runtimeWorkspaceId}
- refreshToken={permissionsRefreshToken}
- />
</SettingsStack>
);
case "appearance":
diff --git a/apps/app/tests/settings-advanced-no-1x-panel.test.ts b/apps/app/tests/settings-advanced-no-1x-panel.test.ts
new file mode 100644
index 00000000..402e79ca
--- /dev/null
+++ b/apps/app/tests/settings-advanced-no-1x-panel.test.ts
@@ -0,0 +1,9 @@
+import { readFileSync } from "node:fs";
+import { fileURLToPath } from "node:url";
+import { expect, test } from "bun:test";
+
+const source = readFileSync(fileURLToPath(new URL("../src/react-app/shell/settings-route.tsx", import.meta.url)), "utf8");
+
+test("Advanced settings no longer show the agent-permissions panel, which read the 1.x engine the app no longer runs", () => {
+ expect(source).not.toContain("<EffectivePermissionsPanel");
+});