Skip to content

A desktop coding agent with free access to frontier models.

TypeScript

fix: remove leftover windows and docker notes

ogsamratcf7b69e7b64c
diff --git a/apps/app/src/app/lib/good-session.ts b/apps/app/src/app/lib/good-session.ts
index 636ebbde..b0e6c8dd 100644
--- a/apps/app/src/app/lib/good-session.ts
+++ b/apps/app/src/app/lib/good-session.ts
@@ -465,7 +465,7 @@ function toolUrl(input: Record<string, unknown>): string {
// --- The checklist -----------------------------------------------------------
-export type GoodSessionCheckId = "code" | "ran" | "project" | "finished" | "windows";
+export type GoodSessionCheckId = "code" | "ran" | "project" | "finished";
/** "warn" comes from the server only. */
export type GoodSessionCheckState = "pass" | "fail" | "warn" | "pending";
diff --git a/apps/app/src/react-app/domains/quality/quality-notice.tsx b/apps/app/src/react-app/domains/quality/quality-notice.tsx
index 4a64a440..6cadcd4f 100644
--- a/apps/app/src/react-app/domains/quality/quality-notice.tsx
+++ b/apps/app/src/react-app/domains/quality/quality-notice.tsx
@@ -31,7 +31,7 @@ const FALLBACK_FAIL_LABELS: Record<string, string> = {
outside_path: "edits outside the project folder",
home_folder: "started in the home folder",
wrong_folder: "started in another folder",
- windows_host: "recorded on Windows",
+ windows_host: "operating system not counted",
small_fix: "a small fix",
one_shot: "a one-shot answer",
non_coding: "not coding work",
diff --git a/apps/app/src/react-app/domains/workspace/create-workspace-local-panel.tsx b/apps/app/src/react-app/domains/workspace/create-workspace-local-panel.tsx
index 71d999da..79c1a064 100644
--- a/apps/app/src/react-app/domains/workspace/create-workspace-local-panel.tsx
+++ b/apps/app/src/react-app/domains/workspace/create-workspace-local-panel.tsx
@@ -4,7 +4,6 @@ import {
Check,
FolderPlus,
Loader2,
- XCircle,
} from "lucide-react";
import { Button } from "@/components/ui/button";
@@ -15,38 +14,15 @@ import {
AccordionTrigger,
} from "@/components/ui/accordion";
import { DialogClose, DialogFooter } from "@/components/ui/dialog";
-import type { WorkspacePreset } from "../../../app/types";
import { t } from "../../../i18n";
-import type { CreateWorkspaceOptions } from "./types";
import {
- errorBannerClass,
modalBodyClass,
- pillGhostClass,
pillSecondaryClass,
sectionBodyClass,
sectionTitleClass,
- softCardClass,
surfaceCardClass,
- tagClass,
- warningBannerClass,
} from "./modal-styles";
-export type CreateWorkspaceProgressStep = {
- key: string;
- label: string;
- status: "pending" | "active" | "done" | "error";
- detail?: string | null;
-};
-
-export type CreateWorkspaceProgressSnapshot = {
- runId: string;
- startedAt: number;
- stage: string;
- error: string | null;
- steps: CreateWorkspaceProgressStep[];
- logs: string[];
-};
-
export type CreateWorkspaceLocalPanelProps = {
selectedFolder: string | null;
hasSelectedFolder: boolean;
@@ -60,53 +36,11 @@ export type CreateWorkspaceLocalPanelProps = {
onClose: () => void;
onSubmit: () => void;
confirmLabel?: string;
- workerLabel?: string;
- onConfirmWorker?: (preset: WorkspacePreset, folder: string | null, options?: CreateWorkspaceOptions) => void;
- preset: WorkspacePreset;
- workerSubmitting: boolean;
- workerDisabled: boolean;
- workerDisabledReason: string | null;
- workerCtaLabel?: string;
- workerCtaDescription?: string;
- onWorkerCta?: () => void;
- workerRetryLabel?: string;
- onWorkerRetry?: () => void;
- workerDebugLines: string[];
- progress: CreateWorkspaceProgressSnapshot | null;
- elapsedSeconds: number;
- showProgressDetails: boolean;
- onToggleProgressDetails: () => void;
};
-function stepIcon(status: CreateWorkspaceProgressStep["status"]) {
- if (status === "done")
- return <XCircle size={16} className="text-emerald-10" />;
- if (status === "active")
- return <Loader2 size={16} className="animate-spin text-dls-accent" />;
- if (status === "error") return <XCircle size={16} className="text-red-10" />;
- return <div className="size-4 rounded-full border-2 border-dls-border" />;
-}
-
-function toKeyedLines(lines: string[]) {
- let offset = 0;
- return lines.map((line) => {
- const key = `${offset}:${line}`;
- offset += line.length + 1;
- return { key, line };
- });
-}
-
-function stepTextClass(status: CreateWorkspaceProgressStep["status"]) {
- if (status === "done") return "text-dls-text font-medium";
- if (status === "active") return "text-dls-text font-semibold";
- if (status === "error") return "text-red-11 font-medium";
- return "text-dls-secondary";
-}
-
export function CreateWorkspaceLocalPanel(
props: CreateWorkspaceLocalPanelProps,
) {
- const progress = props.progress;
const hasProjectLabel = props.projectLabel.trim().length > 0;
return (
@@ -215,131 +149,6 @@ export function CreateWorkspaceLocalPanel(
</div>
<DialogFooter className="flex-col gap-3">
- {props.submitting && progress ? (
- <div className={softCardClass}>
- <div className="flex items-start justify-between gap-3">
- <div className="min-w-0">
- <div className="flex items-center gap-2 text-[12px] font-semibold text-dls-text">
- {progress.error ? (
- <XCircle size={14} className="text-red-11" />
- ) : (
- <Loader2 size={14} className="animate-spin text-dls-accent" />
- )}
- Sandbox setup
- </div>
- <div className="mt-1 truncate text-[14px] leading-snug text-dls-text">
- {progress.stage}
- </div>
- <div className="mt-1 font-mono text-[10px] uppercase tracking-wider text-dls-secondary">
- {props.elapsedSeconds}s
- </div>
- </div>
- <button
- type="button"
- className={pillGhostClass}
- onClick={props.onToggleProgressDetails}
- >
- {props.showProgressDetails ? "Hide logs" : "Show logs"}
- </button>
- </div>
-
- {progress.error ? (
- <div className={`mt-3 ${errorBannerClass}`}>{progress.error}</div>
- ) : null}
-
- <div className="mt-4 grid gap-2.5">
- {progress.steps.map((step) => (
- <div key={step.key} className="flex items-center gap-3">
- <div className="flex size-5 shrink-0 items-center justify-center">
- {stepIcon(step.status)}
- </div>
- <div className="flex min-w-0 flex-1 items-center justify-between gap-2">
- <div
- className={`text-[12px] ${stepTextClass(step.status)} transition-colors duration-200`.trim()}
- >
- {step.label}
- </div>
- {step.detail?.trim() ? (
- <div
- className={`${tagClass} max-w-[120px] truncate font-mono`}
- >
- {step.detail}
- </div>
- ) : null}
- </div>
- </div>
- ))}
- </div>
-
- {props.showProgressDetails && progress.logs.length > 0 ? (
- <div className={`mt-3 ${softCardClass}`}>
- <div className="mb-2 text-[10px] font-semibold uppercase tracking-wide text-dls-secondary">
- Live logs
- </div>
- <div className="max-h-[120px] space-y-0.5 overflow-y-auto">
- {toKeyedLines(progress.logs.slice(-10)).map(({ key, line }) => (
- <div
- key={`${progress.runId}-log-${key}`}
- className="break-all font-mono text-[10px] leading-tight text-dls-text"
- >
- {line}
- </div>
- ))}
- </div>
- </div>
- ) : null}
- </div>
- ) : null}
-
- {props.onConfirmWorker &&
- props.workerDisabled &&
- props.workerDisabledReason ? (
- <div className={warningBannerClass}>
- <div className="font-semibold text-amber-12">
- {t("dashboard.sandbox_get_ready_title")}
- </div>
- <div className="mt-1 leading-relaxed">
- {props.workerDisabledReason || props.workerCtaDescription}
- </div>
- <div className="mt-3 flex flex-wrap items-center gap-2">
- {props.onWorkerCta && props.workerCtaLabel?.trim() ? (
- <button
- type="button"
- className={pillSecondaryClass}
- onClick={props.onWorkerCta}
- disabled={props.submitting}
- >
- {props.workerCtaLabel}
- </button>
- ) : null}
- {props.onWorkerRetry && props.workerRetryLabel?.trim() ? (
- <button
- type="button"
- className={pillGhostClass}
- onClick={props.onWorkerRetry}
- disabled={props.submitting}
- >
- {props.workerRetryLabel}
- </button>
- ) : null}
- </div>
- {props.workerDebugLines.length > 0 ? (
- <details
- className={`mt-3 ${softCardClass} text-[11px] text-dls-text`}
- >
- <summary className="cursor-pointer text-[12px] font-semibold text-dls-text">
- Docker debug details
- </summary>
- <div className="mt-2 space-y-1 break-words font-mono">
- {toKeyedLines(props.workerDebugLines).map(({ key, line }) => (
- <div key={`docker-line-${key}`}>{line}</div>
- ))}
- </div>
- </details>
- ) : null}
- </div>
- ) : null}
-
{props.localError ? (
<div className="mb-3 whitespace-pre-line rounded-[20px] border border-red-7/20 bg-red-1/40 px-4 py-3 text-[13px] text-red-11">
{props.localError}
@@ -353,38 +162,6 @@ export function CreateWorkspaceLocalPanel(
>
{t("common.cancel")}
</DialogClose>
- {props.onConfirmWorker ? (
- <Button
- type="button"
- variant="secondary"
- onClick={() =>
- props.onConfirmWorker?.(props.preset, props.selectedFolder, {
- projectLabel: props.projectLabel.trim() || null,
- })
- }
- disabled={
- !props.selectedFolder ||
- props.submitting ||
- props.workerSubmitting ||
- props.workerDisabled
- }
- title={
- !props.selectedFolder
- ? t("dashboard.choose_folder_continue")
- : props.workerDisabledReason || undefined
- }
- >
- {props.workerSubmitting ? (
- <span className="inline-flex items-center gap-2">
- <Loader2 size={16} className="animate-spin" />
- {t("dashboard.sandbox_checking_docker")}
- </span>
- ) : (
- (props.workerLabel ??
- t("dashboard.create_sandbox_confirm"))
- )}
- </Button>
- ) : null}
<Button
type="button"
onClick={() => void props.onSubmit()}
diff --git a/apps/app/src/react-app/domains/workspace/create-workspace-modal.tsx b/apps/app/src/react-app/domains/workspace/create-workspace-modal.tsx
index 39d189d5..ada2e025 100644
--- a/apps/app/src/react-app/domains/workspace/create-workspace-modal.tsx
+++ b/apps/app/src/react-app/domains/workspace/create-workspace-modal.tsx
@@ -1,7 +1,6 @@
/** @jsxImportSource react */
import {
useEffect,
- useMemo,
useReducer,
useRef,
type SetStateAction,
@@ -24,7 +23,6 @@ import { CreateWorkspaceLocalPanel } from "./create-workspace-local-panel";
import {
createInitialWorkspaceLocalState,
createWorkspaceLocalReducer,
- shouldTickWorkspaceElapsedClock,
type CreateWorkspaceLocalState,
} from "./create-workspace-modal-state";
import {
@@ -52,8 +50,6 @@ export function CreateWorkspaceModal(props: CreateWorkspaceModalProps) {
screen,
selectedFolder,
pickingFolder,
- showProgressDetails,
- now,
projectLabel,
remoteUrl,
remoteToken,
@@ -67,8 +63,6 @@ export function CreateWorkspaceModal(props: CreateWorkspaceModalProps) {
const setScreen = (value: SetStateAction<CreateWorkspaceScreen>) => setLocal("screen", value);
const setSelectedFolder = (value: SetStateAction<string | null>) => setLocal("selectedFolder", value);
const setPickingFolder = (value: SetStateAction<boolean>) => setLocal("pickingFolder", value);
- const setShowProgressDetails = (value: SetStateAction<boolean>) => setLocal("showProgressDetails", value);
- const setNow = (value: SetStateAction<number>) => setLocal("now", value);
const setProjectLabel = (value: SetStateAction<string>) => setLocal("projectLabel", value);
const setRemoteUrl = (value: SetStateAction<string>) => setLocal("remoteUrl", value);
const setRemoteToken = (value: SetStateAction<string>) => setLocal("remoteToken", value);
@@ -79,25 +73,10 @@ export function CreateWorkspaceModal(props: CreateWorkspaceModalProps) {
const showClose = props.showClose ?? true;
const submitting = props.submitting ?? false;
const remoteSubmitting = props.remoteSubmitting ?? false;
- const workerSubmitting = props.workerSubmitting ?? false;
- const progress = props.submittingProgress ?? null;
- const workerDisabled = Boolean(props.workerDisabled);
const showProjectLabel = props.showProjectLabel ?? true;
- const workerDisabledReason = (props.workerDisabledReason ?? "").trim();
- const workerDebugLines = useMemo(
- () => (props.workerDebugLines ?? []).flatMap((line) => {
- const trimmed = line.trim();
- return trimmed ? [trimmed] : [];
- }),
- [props.workerDebugLines],
- );
const hasSelectedFolder = Boolean(selectedFolder?.trim());
const localError = (props.localError ?? "").trim() || null;
const remoteError = (props.remoteError ?? "").trim() || null;
- const elapsedSeconds = useMemo(() => {
- if (!progress?.startedAt) return 0;
- return Math.max(0, Math.floor((now - progress.startedAt) / 1000));
- }, [now, progress]);
const headerTitle = (() => {
switch (screen) {
@@ -127,23 +106,6 @@ export function CreateWorkspaceModal(props: CreateWorkspaceModalProps) {
dispatchLocal({ type: "reset" });
}, [props.open]);
- // The modal remains mounted when closed. Only publish elapsed-time updates
- // while its progress UI is both visible and backed by a real start time.
- useEffect(() => {
- if (!submitting) {
- setShowProgressDetails(false);
- }
- if (!shouldTickWorkspaceElapsedClock({
- open: props.open,
- submitting,
- startedAt: progress?.startedAt,
- })) return;
-
- setNow(Date.now());
- const id = window.setInterval(() => setNow(Date.now()), 1_000);
- return () => window.clearInterval(id);
- }, [progress?.startedAt, props.open, submitting]);
-
// Focus the URL field when the remote screen opens.
useEffect(() => {
if (!props.open) return;
@@ -284,24 +246,6 @@ export function CreateWorkspaceModal(props: CreateWorkspaceModalProps) {
onClose={props.onClose}
onSubmit={() => void handleLocalSubmit()}
confirmLabel={props.confirmLabel}
- workerLabel={props.workerLabel}
- onConfirmWorker={props.onConfirmWorker}
- preset={preset}
- workerSubmitting={workerSubmitting}
- workerDisabled={workerDisabled}
- workerDisabledReason={workerDisabledReason}
- workerCtaLabel={props.workerCtaLabel}
- workerCtaDescription={props.workerCtaDescription}
- onWorkerCta={props.onWorkerCta}
- workerRetryLabel={props.workerRetryLabel}
- onWorkerRetry={props.onWorkerRetry}
- workerDebugLines={workerDebugLines}
- progress={progress}
- elapsedSeconds={elapsedSeconds}
- showProgressDetails={showProgressDetails}
- onToggleProgressDetails={() =>
- setShowProgressDetails((prev) => !prev)
- }
/>
) : null}
diff --git a/apps/app/src/react-app/domains/workspace/types.ts b/apps/app/src/react-app/domains/workspace/types.ts
index 0f877ba3..2c1ec795 100644
--- a/apps/app/src/react-app/domains/workspace/types.ts
+++ b/apps/app/src/react-app/domains/workspace/types.ts
@@ -20,26 +20,11 @@ export type CreateWorkspaceOptions = {
firstTaskAttachments?: ComposerAttachment[] | null;
};
-export type CreateWorkspaceProgress = {
- runId: string;
- startedAt: number;
- stage: string;
- error: string | null;
- steps: Array<{
- key: string;
- label: string;
- status: "pending" | "active" | "done" | "error";
- detail?: string | null;
- }>;
- logs: string[];
-};
-
export type CreateWorkspaceModalProps = {
open: boolean;
onClose: () => void;
onConfirm: (preset: WorkspacePreset, folder: string | null, options?: CreateWorkspaceOptions) => void;
onConfirmRemote?: (input: RemoteWorkspaceInput) => Promise<boolean> | boolean | void;
- onConfirmWorker?: (preset: WorkspacePreset, folder: string | null, options?: CreateWorkspaceOptions) => void;
onPickFolder: () => Promise<string | null>;
onImportConfig?: () => void;
importingConfig?: boolean;
@@ -53,17 +38,6 @@ export type CreateWorkspaceModalProps = {
title?: string;
subtitle?: string;
confirmLabel?: string;
- workerLabel?: string;
- workerDisabled?: boolean;
- workerDisabledReason?: string | null;
- workerCtaLabel?: string;
- workerCtaDescription?: string;
- onWorkerCta?: () => void;
- workerRetryLabel?: string;
- onWorkerRetry?: () => void;
- workerDebugLines?: string[];
- workerSubmitting?: boolean;
- submittingProgress?: CreateWorkspaceProgress | null;
localDisabled?: boolean;
localDisabledReason?: string | null;
};
diff --git a/apps/desktop/electron/quality.mjs b/apps/desktop/electron/quality.mjs
index d43394f6..d1bdd85f 100644
--- a/apps/desktop/electron/quality.mjs
+++ b/apps/desktop/electron/quality.mjs
@@ -145,8 +145,8 @@ export function parseAccountQuality(value) {
nextSpinHint: parseNextSpinHint(value.next_spin_hint),
biggestWinToday: parseBiggestWin(value.biggest_win_today),
nudge: parseNudge(value.nudge),
- // The server counts native-Windows sessions for a Good session ★ (absent: it does not).
- windowsCounts: value.windows_counts === true,
+ // Native Windows counts like every other system unless the server says otherwise.
+ windowsCounts: value.windows_counts !== false,
};
}
diff --git a/apps/desktop/electron/quality.test.mjs b/apps/desktop/electron/quality.test.mjs
index a79e25e7..e22536e9 100644
--- a/apps/desktop/electron/quality.test.mjs
+++ b/apps/desktop/electron/quality.test.mjs
@@ -96,17 +96,17 @@ test("quality block parses every field, including revision 2", () => {
nextSpinHint: { progress: 0.6, text: "Add tests to earn a spin.", sessionId: "ses_1" },
biggestWinToday: { tokens: 10000000, at: "2026-10-04T09:00:00Z" },
nudge: null,
- windowsCounts: false,
+ windowsCounts: true,
});
// A server without `notices` still has its one `notice`.
const legacy = parseAccountQuality({ tier: "limited", tokens_multiplier: 0.3, notice: { id: "n", title: "Hi" } });
assert.equal(legacy.notices[0].id, "n");
assert.equal(legacy.tokensMultiplier, 0.3);
assert.equal(legacy.preview, false);
- // Native Windows counts for a Good session ★ only when the server says so.
- assert.equal(legacy.windowsCounts, false);
+ // Native Windows counts unless the server says it does not.
+ assert.equal(legacy.windowsCounts, true);
assert.equal(parseAccountQuality({ ...QUALITY, windows_counts: true }).windowsCounts, true);
- assert.equal(parseAccountQuality({ ...QUALITY, windows_counts: "true" }).windowsCounts, false);
+ assert.equal(parseAccountQuality({ ...QUALITY, windows_counts: false }).windowsCounts, false);
});
test("a spin answer must name a segment the wheel can land on", () => {