A desktop coding agent with free access to frontier models.
TypeScript
fix: classify engine store query errors
Samrat Talukdard470f9215abd
diff --git a/apps/desktop/electron/main.mjs b/apps/desktop/electron/main.mjsindex da5f990a..d802572c 100644--- a/apps/desktop/electron/main.mjs+++ b/apps/desktop/electron/main.mjs@@ -1545,11 +1545,16 @@ async function reportStartFailure(input = {}) {elapsedMs: failure.elapsedMs,attempt: failure.attempt,};- const category = buildStartFailureReport(draft).category;+ let category = buildStartFailureReport(draft).category;// Which store files cannot be written, and whether this start runs elevated (start-store-check.mjs).const storeCheck = category === "store_readonly" || category === "store_error"? await checkStoreAccess({ files: startStoreFiles() }).catch(() => null): null;+ // A store error whose files cannot be written is a read-only store (the engine only says "Failed query").+ if (category === "store_error" && storeCheck?.blockedStores.length) {+ category = "store_readonly";+ classified.category = "store_readonly";+ }const engineStoreFailed = classified.phase === "engine_ready" || storeCheck?.blockedStores.includes("engine") === true;// Reset app data moves the engine's data (chats, sessions not yet uploaded) only when its store failed.const resetIncludesChats = (category === "store_error" || category === "store_readonly") && engineStoreFailed;diff --git a/apps/desktop/electron/start-report.mjs b/apps/desktop/electron/start-report.mjsindex 4c910525..dcce19b2 100644--- a/apps/desktop/electron/start-report.mjs+++ b/apps/desktop/electron/start-report.mjs@@ -119,6 +119,8 @@ export function engineErrorKind(line) {if (!text) return "none";const sqlite = sqliteCodeOf(null, text);if (sqlite) return sqlite.toLowerCase();+ // Drizzle's wrapper around a failed SQLite statement (the SQLite error itself is only in its cause).+ if (/^Failed query:/i.test(text)) return "sqlite_query";if (/migrat/i.test(text)) return "migration";if (/\bEPERM\b|operation not permitted/i.test(text)) return "eperm";if (/\bEACCES\b|permission denied|access is denied/i.test(text)) return "eacces";@@ -225,6 +227,8 @@ export function classifyStartFailure(rawError, { fallbackPhase = "unknown" } = {return set("config_invalid", "engine_ready");}if (sqliteCode === "SQLITE_READONLY") return set("store_readonly", "engine_ready", { errorCode: "SQLITE_READONLY" });+ // The engine's store refused a statement (a read-only, locked or damaged opencode.db).+ if (engineLine && engineErrorKind(engineLine) === "sqlite_query") return set("store_error", "engine_ready");if (sqlite) return set("store_error", "engine_ready", { errorCode: knownCode(sqlite[1]) ?? result.errorCode });if ((status !== null && status >= 0xc0000000) || signal) return set("engine_crash", "engine_ready");return set("engine_exit", "engine_ready");diff --git a/apps/desktop/electron/start-report.test.mjs b/apps/desktop/electron/start-report.test.mjsindex 9bb26da5..774f60a6 100644--- a/apps/desktop/electron/start-report.test.mjs+++ b/apps/desktop/electron/start-report.test.mjs@@ -357,6 +357,8 @@ test("an engine exit keeps the engine's own error line and its kind", () => {["EPERM: operation not permitted, rename 'C:\\Users\\Ana\\AppData\\Roaming\\ai.omnirush.desktop\\engine-data\\omnirush\\x.tmp'", "eperm"],["Migration 20260101_session failed", "migration"],["JSON Parse error: Unexpected EOF", "json"],+ // What the engine printed on the VM with a read-only opencode.db.+ ["Failed query: PRAGMA wal_checkpoint(PASSIVE)", "sqlite_query"],["undefined is not an object (evaluating 'x.y')", "internal"],["something unusual", "other"],];@@ -369,6 +371,11 @@ test("an engine exit keeps the engine's own error line and its kind", () => {assert.doesNotMatch(text, /\u001b|Unexpected error|Ana|\\/, text);assert.doesNotMatch(text, SERVER_DROP, text);}+ const checkpoint = exitError(1, `${banner}\nFailed query: PRAGMA wal_checkpoint(PASSIVE)`);+ assert.deepEqual(+ (({ category, phase }) => ({ category, phase }))(classifyStartFailure(checkpoint)),+ { category: "store_error", phase: "engine_ready" },+ );assert.equal(engineErrorLine("boom"), null);assert.equal(engineErrorKind(null), "none");});