Skip to content

A desktop coding agent with free access to frontier models.

TypeScript

fix: name a container as the sandbox blocker

ogsamratd741b0f16f2a
diff --git a/apps/desktop/box/go/cmd/boxrun/main.go b/apps/desktop/box/go/cmd/boxrun/main.go
index 7d69a6ca..c6a2ce73 100644
--- a/apps/desktop/box/go/cmd/boxrun/main.go
+++ b/apps/desktop/box/go/cmd/boxrun/main.go
@@ -503,19 +503,35 @@ func probe(bwAsked, fuseAsked, dir string) probeResult {
// classify turns a failed namespace start into one line for the user.
func classify(r probeResult, text string, fail func(code, reason, detail string) probeResult) probeResult {
low := strings.ToLower(text)
+ // bwrap could not even create the namespace (clone refused). Ubuntu's AppArmor
+ // rule lets that through and denies what comes after (the uid map), so this is
+ // never AppArmor: a container's seccomp filter, or namespaces turned off.
+ refused := strings.Contains(low, "no permissions to creat")
switch {
- case r.AppArmor != nil && *r.AppArmor == 1:
+ case refused && inContainer():
+ return fail("container", "this runs in a container that does not allow user namespaces (its seccomp profile)", text)
+ case !refused && r.AppArmor != nil && *r.AppArmor == 1:
return fail("apparmor", "AppArmor blocks unprivileged user namespaces (kernel.apparmor_restrict_unprivileged_userns=1, Ubuntu 23.10+)", text)
case r.UsernsClone != nil && *r.UsernsClone == 0:
return fail("userns_off", "unprivileged user namespaces are off (kernel.unprivileged_userns_clone=0)", text)
case r.MaxUserNS != nil && *r.MaxUserNS == 0:
return fail("userns_off", "user namespaces are off (user.max_user_namespaces=0)", text)
- case strings.Contains(low, "setting up uid map") || strings.Contains(low, "uid_map") || strings.Contains(low, "operation not permitted") || strings.Contains(low, "permission denied"):
+ case refused || strings.Contains(low, "setting up uid map") || strings.Contains(low, "uid_map") || strings.Contains(low, "operation not permitted") || strings.Contains(low, "permission denied"):
return fail("userns_denied", "this system does not let unprivileged users create namespaces (a container or a hardened kernel)", text)
}
return fail("start", "bubblewrap could not start a namespace", text)
}
+// inContainer: this process runs in a Docker/Podman (or similar) container.
+var inContainer = func() bool {
+ for _, f := range []string{"/.dockerenv", "/run/.containerenv"} {
+ if _, err := os.Stat(f); err == nil {
+ return true
+ }
+ }
+ return os.Getenv("container") != ""
+}
+
// probeInner runs inside the probe's namespaces: can overlayfs mount here?
func probeInner(args []string) {
out := map[string]any{"uid": os.Getuid()}
diff --git a/apps/desktop/box/go/cmd/boxrun/main_test.go b/apps/desktop/box/go/cmd/boxrun/main_test.go
index ccff5fca..f7abf67d 100644
--- a/apps/desktop/box/go/cmd/boxrun/main_test.go
+++ b/apps/desktop/box/go/cmd/boxrun/main_test.go
@@ -77,6 +77,22 @@ func TestClassify(t *testing.T) {
if r.Code != "userns_denied" {
t.Fatal(r)
}
+ // In a container (Docker's seccomp refuses the clone) the host's AppArmor sysctl is
+ // visible but is not what blocks it.
+ refused := "bwrap: No permissions to creating new namespace, likely because the kernel does not allow non-privileged user namespaces."
+ was := inContainer
+ defer func() { inContainer = was }()
+ inContainer = func() bool { return true }
+ if r = classify(probeResult{AppArmor: &one}, refused, fail); r.Code != "container" {
+ t.Fatal(r)
+ }
+ inContainer = func() bool { return false }
+ if r = classify(probeResult{AppArmor: &one}, refused, fail); r.Code != "userns_denied" {
+ t.Fatal(r)
+ }
+ if r = classify(probeResult{AppArmor: &one}, "bwrap: setting up uid map: Permission denied", fail); r.Code != "apparmor" {
+ t.Fatal(r)
+ }
}
func TestAlive(t *testing.T) {
diff --git a/apps/server/src/box/backends/bwrap.ts b/apps/server/src/box/backends/bwrap.ts
index 0a5d9e75..33fb8dd0 100644
--- a/apps/server/src/box/backends/bwrap.ts
+++ b/apps/server/src/box/backends/bwrap.ts
@@ -78,6 +78,8 @@ export function explainProbe(out: Record<string, unknown> | null): string {
return `${reason} (\`sudo apt install bubblewrap\` or your system's package)`;
case "userns_off":
return `${reason}; an admin can allow them, or use Podman or Docker`;
+ case "container":
+ return `${reason}; run OmniRush on the host, or give this container a Docker or Podman engine`;
default:
return reason;
}