The Unified and Autonomous Development Platform
fix: Onedev ci/cd Cache breaking when trying to find some files with escape characters. (OD-2691)
Robin Shen08df944ec2d1
diff --git a/server-core/src/main/java/io/onedev/server/search/commit/Revision.java b/server-core/src/main/java/io/onedev/server/search/commit/Revision.javaindex 63800d8219..b700a75cdc 100644--- a/server-core/src/main/java/io/onedev/server/search/commit/Revision.java+++ b/server-core/src/main/java/io/onedev/server/search/commit/Revision.java@@ -66,7 +66,12 @@ public class Revision implements Serializable {public RevCommit getRevCommit(Project project) {if (type == Type.BRANCH) {- var branch = value != null? value: project.getDefaultBranch();+ String branch = value;+ if (branch == null) {+ branch = project.getDefaultBranch();+ if (branch == null)+ throw new ExplicitException("No default branch");+ }return project.getRevCommit(GitUtils.branch2ref(branch), true);} else if (type == Type.TAG) {return project.getRevCommit(GitUtils.tag2ref(value), true);diff --git a/server-core/src/main/java/io/onedev/server/web/page/builds/BuildListPage.java b/server-core/src/main/java/io/onedev/server/web/page/builds/BuildListPage.javaindex 175a528662..0bbfbde1f5 100644--- a/server-core/src/main/java/io/onedev/server/web/page/builds/BuildListPage.java+++ b/server-core/src/main/java/io/onedev/server/web/page/builds/BuildListPage.java@@ -79,7 +79,7 @@ public class BuildListPage extends LayoutPage {@Overrideprotected QueryPersonalization<NamedBuildQuery> getQueryPersonalization() {- return getLoginUser().getBuildQueryPersonalization();+ return getLoginUser() != null ? getLoginUser().getBuildQueryPersonalization() : null;}@Overridediff --git a/server-core/src/main/java/io/onedev/server/web/page/issues/IssueListPage.java b/server-core/src/main/java/io/onedev/server/web/page/issues/IssueListPage.javaindex d03ed1f523..653715de7f 100644--- a/server-core/src/main/java/io/onedev/server/web/page/issues/IssueListPage.java+++ b/server-core/src/main/java/io/onedev/server/web/page/issues/IssueListPage.java@@ -89,7 +89,7 @@ public class IssueListPage extends LayoutPage {@Overrideprotected QueryPersonalization<NamedIssueQuery> getQueryPersonalization() {- return getLoginUser().getIssueQueryPersonalization();+ return getLoginUser() != null ? getLoginUser().getIssueQueryPersonalization() : null;}@Overridediff --git a/server-core/src/main/java/io/onedev/server/web/page/packs/PackListPage.java b/server-core/src/main/java/io/onedev/server/web/page/packs/PackListPage.javaindex 08d7738f5c..3d3b8c2faa 100644--- a/server-core/src/main/java/io/onedev/server/web/page/packs/PackListPage.java+++ b/server-core/src/main/java/io/onedev/server/web/page/packs/PackListPage.java@@ -79,7 +79,7 @@ public class PackListPage extends LayoutPage {@Overrideprotected QueryPersonalization<NamedPackQuery> getQueryPersonalization() {- return getLoginUser().getPackQueryPersonalization();+ return getLoginUser() != null ? getLoginUser().getPackQueryPersonalization() : null;}@Overridediff --git a/server-core/src/main/java/io/onedev/server/web/page/project/ProjectListPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/ProjectListPage.javaindex 7a24b6e7f8..9b81daa2d4 100644--- a/server-core/src/main/java/io/onedev/server/web/page/project/ProjectListPage.java+++ b/server-core/src/main/java/io/onedev/server/web/page/project/ProjectListPage.java@@ -83,7 +83,7 @@ public class ProjectListPage extends LayoutPage {@Overrideprotected QueryPersonalization<NamedProjectQuery> getQueryPersonalization() {- return getLoginUser().getProjectQueryPersonalization();+ return getLoginUser() != null ? getLoginUser().getProjectQueryPersonalization() : null;}@Overridediff --git a/server-core/src/main/java/io/onedev/server/web/page/pullrequests/PullRequestListPage.java b/server-core/src/main/java/io/onedev/server/web/page/pullrequests/PullRequestListPage.javaindex 6a7925ed57..655d13cf54 100644--- a/server-core/src/main/java/io/onedev/server/web/page/pullrequests/PullRequestListPage.java+++ b/server-core/src/main/java/io/onedev/server/web/page/pullrequests/PullRequestListPage.java@@ -79,7 +79,7 @@ public class PullRequestListPage extends LayoutPage {@Overrideprotected QueryPersonalization<NamedPullRequestQuery> getQueryPersonalization() {- return getLoginUser().getPullRequestQueryPersonalization();+ return getLoginUser() != null ? getLoginUser().getPullRequestQueryPersonalization() : null;}@Override