Skip to content

The Unified and Autonomous Development Platform

chore: Minor feedback message improvements

Robin Shen162dca2472da
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java
index c96039ba54..7dcd01e362 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java
@@ -639,7 +639,7 @@ public abstract class BuildDetailPage extends ProjectPage
var oldAuditContent = VersionedXmlDoc.fromBean(getBuild()).toXML();
auditService.audit(getBuild().getProject(), "deleted build \"" + getBuild().getReference().toString(getBuild().getProject()) + "\"", oldAuditContent, null);
- Session.get().success(MessageFormat.format(_T("Build #{0} deleted"), getBuild().getNumber()));
+ Session.get().success(MessageFormat.format(_T("Build {0} deleted"), getBuild().getReference().toString(getBuild().getProject())));
String redirectUrlAfterDelete = WebSession.get().getRedirectUrlAfterDelete(Build.class);
if (redirectUrlAfterDelete != null)
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/InvalidBuildPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/InvalidBuildPage.java
index 1ba4e96e3d..8f22a53b9c 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/InvalidBuildPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/InvalidBuildPage.java
@@ -69,7 +69,7 @@ public class InvalidBuildPage extends ProjectPage {
public void onClick() {
OneDev.getInstance(BuildService.class).delete(getBuild());
- Session.get().success(MessageFormat.format(_T("Build #{0} deleted"), getBuild().getNumber()));
+ Session.get().success(MessageFormat.format(_T("Build {0} deleted"), getBuild().getReference().toString(getBuild().getProject())));
String redirectUrlAfterDelete = WebSession.get().getRedirectUrlAfterDelete(Build.class);
if (redirectUrlAfterDelete != null)
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.java
index 562d5b5145..272166c25a 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.java
@@ -312,7 +312,7 @@ public abstract class IssueDetailPage extends ProjectIssuesPage implements Input
var oldAuditContent = VersionedXmlDoc.fromBean(getIssue()).toXML();
auditService.audit(getIssue().getProject(), "deleted issue \"" + getIssue().getReference().toString(getIssue().getProject()) + "\"", oldAuditContent, null);
- Session.get().success(MessageFormat.format(_T("Issue #{0} deleted"), getIssue().getNumber()));
+ Session.get().success(MessageFormat.format(_T("Issue {0} deleted"), getIssue().getReference().toString(getIssue().getProject())));
String redirectUrlAfterDelete = WebSession.get().getRedirectUrlAfterDelete(Issue.class);
if (redirectUrlAfterDelete != null)
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/InvalidPullRequestPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/InvalidPullRequestPage.java
index a8e7ef9b5d..2db8286f4f 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/InvalidPullRequestPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/InvalidPullRequestPage.java
@@ -83,7 +83,7 @@ public class InvalidPullRequestPage extends ProjectPage {
public void onClick() {
OneDev.getInstance(PullRequestService.class).delete(getPullRequest());
- Session.get().success(MessageFormat.format(_T("Pull request #{0} deleted"), getPullRequest().getNumber()));
+ Session.get().success(MessageFormat.format(_T("Pull request {0} deleted"), getPullRequest().getReference().toString(getPullRequest().getProject())));
String redirectUrlAfterDelete = WebSession.get().getRedirectUrlAfterDelete(PullRequest.class);
if (redirectUrlAfterDelete != null)
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/PullRequestDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/PullRequestDetailPage.java
index b7aa766266..318e5573c2 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/PullRequestDetailPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/PullRequestDetailPage.java
@@ -1255,7 +1255,7 @@ public abstract class PullRequestDetailPage extends ProjectPage implements PullR
var oldAuditContent = VersionedXmlDoc.fromBean(request).toXML();
auditService.audit(request.getProject(), "deleted pull request \"" + request.getReference().toString(request.getProject()) + "\"", oldAuditContent, null);
- Session.get().success(MessageFormat.format(_T("Pull request #{0} deleted"), request.getNumber()));
+ Session.get().success(MessageFormat.format(_T("Pull request {0} deleted"), request.getReference().toString(request.getProject())));
String redirectUrlAfterDelete = WebSession.get().getRedirectUrlAfterDelete(PullRequest.class);
if (redirectUrlAfterDelete != null)