Skip to content

The Unified and Autonomous Development Platform

Do not hide job secret value when edit to avoid confusion

Robin Shen16e365d532e3
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.java
index a6857fcdb5..0fd5123c5f 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.java
@@ -37,12 +37,10 @@ public abstract class JobSecretEditPanel extends Panel {
form.setOutputMarkupId(true);
JobSecret editingSecret;
- if (index != -1) {
+ if (index != -1)
editingSecret = getProject().getBuildSetting().getJobSecrets().get(index);
- editingSecret.setValue(null);
- } else {
+ else
editingSecret = new JobSecret();
- }
BeanEditor editor = BeanContext.edit("editor", editingSecret);
form.add(editor);