The Unified and Autonomous Development Platform
Fix issue #944 - Sanitize uploaded attachment name to avoid possible file override
Robin Shen172be7b2a23e
diff --git a/server-core/src/main/java/io/onedev/server/model/Project.java b/server-core/src/main/java/io/onedev/server/model/Project.javaindex ca44642b3c..46f2453237 100644--- a/server-core/src/main/java/io/onedev/server/model/Project.java+++ b/server-core/src/main/java/io/onedev/server/model/Project.java@@ -1755,6 +1755,8 @@ public class Project extends AbstractEntity {}public String saveAttachment(String attachmentGroup, String suggestedAttachmentName, InputStream attachmentStream) {+ suggestedAttachmentName = suggestedAttachmentName.replace("..", "-");+String attachmentName = suggestedAttachmentName;File attachmentDir = OneDev.getInstance(AttachmentStorageManager.class).getGroupDir(this, attachmentGroup);