Skip to content

The Unified and Autonomous Development Platform

chore: Report error when project not specified when push

Robin Shen189c4818ec6d
diff --git a/server-core/src/main/java/io/onedev/server/git/GitFilter.java b/server-core/src/main/java/io/onedev/server/git/GitFilter.java
index 9d190e4b6f..9d000cc3a6 100644
--- a/server-core/src/main/java/io/onedev/server/git/GitFilter.java
+++ b/server-core/src/main/java/io/onedev/server/git/GitFilter.java
@@ -94,6 +94,8 @@ public class GitFilter implements Filter {
projectPath = StringUtils.substringBeforeLast(projectPath, ".");
facade = projectManager.findFacadeByPath(projectPath);
}
+ if (StringUtils.isBlank(projectPath))
+ throw new ExplicitException("Project not specified");
if (facade == null) {
if (clusterAccess || upload) {
throw new ExplicitException(String.format("Unable to find project '%s'", projectPath));
diff --git a/server-core/src/main/java/io/onedev/server/git/GitLfsFilter.java b/server-core/src/main/java/io/onedev/server/git/GitLfsFilter.java
index 2b7b5bf045..2826bdaaa7 100644
--- a/server-core/src/main/java/io/onedev/server/git/GitLfsFilter.java
+++ b/server-core/src/main/java/io/onedev/server/git/GitLfsFilter.java
@@ -3,6 +3,7 @@ package io.onedev.server.git;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.common.hash.HashingInputStream;
+import io.onedev.commons.utils.ExplicitException;
import io.onedev.k8shelper.KubernetesHelper;
import io.onedev.server.OneDev;
import io.onedev.server.cluster.ClusterManager;
@@ -117,7 +118,10 @@ public class GitLfsFilter implements Filter {
}
private String getProjectPath(String pathInfo) {
- return StringUtils.substringBeforeLast(pathInfo, ".git/");
+ String projectPath = StringUtils.substringBeforeLast(pathInfo, ".git/");
+ if (StringUtils.isBlank(projectPath))
+ throw new ExplicitException("Project not specified");
+ return projectPath;
}
@Override
diff --git a/server-core/src/main/java/io/onedev/server/git/SshCommand.java b/server-core/src/main/java/io/onedev/server/git/SshCommand.java
index 615f33a6f5..c538c3dadc 100644
--- a/server-core/src/main/java/io/onedev/server/git/SshCommand.java
+++ b/server-core/src/main/java/io/onedev/server/git/SshCommand.java
@@ -1,6 +1,7 @@
package io.onedev.server.git;
import com.google.common.base.Preconditions;
+import io.onedev.commons.utils.ExplicitException;
import io.onedev.commons.utils.StringUtils;
import io.onedev.commons.utils.command.ExecutionResult;
import io.onedev.server.OneDev;
@@ -86,6 +87,8 @@ class SshCommand implements Command, ServerSessionAware {
projectPath = StringUtils.substringBeforeLast(projectPath, ".");
projectFacade = projectManager.findFacadeByPath(projectPath);
}
+ if (StringUtils.isBlank(projectPath))
+ throw new ExplicitException("Project not specified");
if (projectFacade == null) {
if (clusterAccess || upload) {
onExit(-1, "Unable to find project '" + projectPath + "'");