Skip to content

The Unified and Autonomous Development Platform

fix: XSS attack able to be exploited by users with package write permissions

Robin Shen21931fff8b54
diff --git a/server-plugin/server-plugin-pack-maven/src/main/java/io/onedev/server/plugin/pack/maven/MavenPackPanel.java b/server-plugin/server-plugin-pack-maven/src/main/java/io/onedev/server/plugin/pack/maven/MavenPackPanel.java
index 2f700c2008..58d1d130df 100644
--- a/server-plugin/server-plugin-pack-maven/src/main/java/io/onedev/server/plugin/pack/maven/MavenPackPanel.java
+++ b/server-plugin/server-plugin-pack-maven/src/main/java/io/onedev/server/plugin/pack/maven/MavenPackPanel.java
@@ -118,7 +118,7 @@ public class MavenPackPanel extends GenericPanel<Pack> {
var packaging = pomElement.elementText("packaging");
if (packaging == null)
packaging = "jar";
- var description = "<b>Packaging: " + packaging + "</b>";
+ var description = "<b>Packaging: " + HtmlEscape.escapeHtml5(packaging) + "</b>";
var descriptionElement = pomElement.element("description");
if (descriptionElement != null)
description += "<br><br>" + HtmlEscape.escapeHtml5(descriptionElement.getText());