Skip to content

The Unified and Autonomous Development Platform

fix: Got Error when click changes in PR (OD-2128)

Robin Shen24ef92164c76
diff --git a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageModule.java b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageModule.java
index 90a690787a..9b18b1f78f 100644
--- a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageModule.java
+++ b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageModule.java
@@ -20,8 +20,11 @@ import io.onedev.server.web.page.project.StatisticsMenuContribution;
import io.onedev.server.web.page.project.builds.detail.BuildTab;
import io.onedev.server.web.page.project.builds.detail.BuildTabContribution;
import io.onedev.server.web.page.project.builds.detail.report.BuildReportTab;
+import org.apache.commons.lang.SerializationException;
import org.apache.commons.lang.SerializationUtils;
import org.apache.wicket.request.mapper.parameter.PageParameters;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import javax.annotation.Nullable;
import java.io.BufferedInputStream;
@@ -43,6 +46,8 @@ import static io.onedev.server.util.DirectoryVersionUtils.isVersionFile;
*/
public class CoverageModule extends AbstractPluginModule {
+ private static final Logger logger = LoggerFactory.getLogger(CoverageModule.class);
+
@Override
protected void configure() {
super.configure();
@@ -180,8 +185,10 @@ public class CoverageModule extends AbstractPluginModule {
if (reportName == null || reportName.equals(reportDir.getName())) {
File lineCoveragesFile = new File(reportDir, CoverageStats.FILES + "/" + blobPath);
if (lineCoveragesFile.exists()) {
- try (InputStream is = new BufferedInputStream(new FileInputStream(lineCoveragesFile))) {
+ try (var is = new BufferedInputStream(new FileInputStream(lineCoveragesFile))) {
coverages.put(reportDir.getName(), (Map<Integer, CoverageStatus>) SerializationUtils.deserialize(is));
+ } catch (SerializationException e) {
+ logger.error("Error reading coverage status: " + lineCoveragesFile, e);
}
}
}
diff --git a/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemModule.java b/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemModule.java
index e98465c82c..89347b754d 100644
--- a/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemModule.java
+++ b/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemModule.java
@@ -20,8 +20,11 @@ import io.onedev.server.web.page.project.StatisticsMenuContribution;
import io.onedev.server.web.page.project.builds.detail.BuildTab;
import io.onedev.server.web.page.project.builds.detail.BuildTabContribution;
import io.onedev.server.web.page.project.builds.detail.report.BuildReportTab;
+import org.apache.commons.lang.SerializationException;
import org.apache.commons.lang.SerializationUtils;
import org.apache.wicket.request.mapper.parameter.PageParameters;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import javax.annotation.Nullable;
import java.io.BufferedInputStream;
@@ -43,6 +46,8 @@ import static io.onedev.server.util.DirectoryVersionUtils.isVersionFile;
*/
public class ProblemModule extends AbstractPluginModule {
+ private static final Logger logger = LoggerFactory.getLogger(ProblemModule.class);
+
@Override
protected void configure() {
super.configure();
@@ -150,6 +155,8 @@ public class ProblemModule extends AbstractPluginModule {
if (file.exists()) {
try (InputStream is = new BufferedInputStream(new FileInputStream(file))) {
problems.put(reportDir.getName(), (Collection<CodeProblem>) SerializationUtils.deserialize(is));
+ } catch (SerializationException e) {
+ logger.error("Error reading problem report: " + file, e);
}
}
}