Skip to content

The Unified and Autonomous Development Platform

feat: Add rebuild and create issue functionality to build detail page

Robin Shen2dcd5cfc9c64
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java
index ac1e9acaeb..5040605f93 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java
@@ -217,6 +217,57 @@ public abstract class BuildDetailPage extends ProjectPage
};
}
+ protected Component newRebuildLink(String componentId) {
+ return new AjaxLink<Void>(componentId) {
+
+ @Override
+ protected void updateAjaxAttributes(AjaxRequestAttributes attributes) {
+ super.updateAjaxAttributes(attributes);
+ attributes.getAjaxCallListeners().add(new ConfirmClickListener(_T("Do you really want to rebuild?")));
+ }
+
+ private void resubmit(Serializable paramBean) {
+ var user = SecurityUtils.getUser();
+ jobService.resubmit(user, getBuild(), _T("Resubmitted manually"));
+ setResponsePage(BuildDefaultPage.class, BuildDefaultPage.paramsOf(getBuild()));
+ }
+
+ @Override
+ public void onClick(AjaxRequestTarget target) {
+ resubmit(getBuild().getParamBean());
+ target.focusComponent(null);
+ }
+
+ @Override
+ protected void onConfigure() {
+ super.onConfigure();
+ setVisible(getBuild().isFinished() && getBuild().getJob() != null
+ && SecurityUtils.canRunJob(getProject(), getBuild().getJobName()));
+ }
+
+ }.setOutputMarkupId(true);
+ }
+
+ protected Component newCreateIssueLink(String componentId) {
+ return new AjaxLink<Void>(componentId) {
+
+ @Override
+ public void onClick(AjaxRequestTarget target) {
+ var prompt = settingService.getAiSetting().getBuildFailureIssuePrompt();
+ getAssistant().show(target, prompt + " Display in " + getSession().getLocale().getDisplayLanguage());
+ }
+
+ @Override
+ protected void onConfigure() {
+ super.onConfigure();
+ setVisible(getBuild().isFailed()
+ && SecurityUtils.canWriteCode(getProject())
+ && !getAssistant().getEntitledAis().isEmpty());
+ }
+
+ }.setOutputMarkupId(true);
+ }
+
protected Component newCancelLink(String componentId) {
return new AjaxLink<Void>(componentId) {
@@ -323,34 +374,7 @@ public abstract class BuildDetailPage extends ProjectPage
@Override
protected void onInitialize() {
super.onInitialize();
- add(new AjaxLink<Void>("rebuild") {
-
- @Override
- protected void updateAjaxAttributes(AjaxRequestAttributes attributes) {
- super.updateAjaxAttributes(attributes);
- attributes.getAjaxCallListeners().add(new ConfirmClickListener(_T("Do you really want to rebuild?")));
- }
-
- private void resubmit(Serializable paramBean) {
- var user = SecurityUtils.getUser();
- jobService.resubmit(user, getBuild(), _T("Resubmitted manually"));
- setResponsePage(BuildDefaultPage.class, BuildDefaultPage.paramsOf(getBuild()));
- }
-
- @Override
- public void onClick(AjaxRequestTarget target) {
- resubmit(getBuild().getParamBean());
- target.focusComponent(null);
- }
-
- @Override
- protected void onConfigure() {
- super.onConfigure();
- setVisible(getBuild().isFinished() && getBuild().getJob() != null
- && SecurityUtils.canRunJob(getProject(), getBuild().getJobName()));
- }
-
- }.setOutputMarkupId(true));
+ add(newRebuildLink("rebuild"));
add(newCancelLink("cancel"));
@@ -389,7 +413,7 @@ public abstract class BuildDetailPage extends ProjectPage
@Override
protected void onConfigure() {
super.onConfigure();
- setVisible(!promotionsModel.getObject().isEmpty());
+ setVisible(getBuild().isFinished() && !promotionsModel.getObject().isEmpty());
}
});
@@ -455,23 +479,7 @@ public abstract class BuildDetailPage extends ProjectPage
});
- add(new AjaxLink<Void>("createIssue") {
-
- @Override
- public void onClick(AjaxRequestTarget target) {
- var prompt = settingService.getAiSetting().getBuildFailureIssuePrompt();
- getAssistant().show(target, prompt + " Display in " + getSession().getLocale().getDisplayLanguage());
- }
-
- @Override
- protected void onConfigure() {
- super.onConfigure();
- setVisible(getBuild().isFailed()
- && SecurityUtils.canWriteCode(getProject())
- && !getAssistant().getEntitledAis().isEmpty());
- }
-
- });
+ add(newCreateIssueLink("createIssue"));
add(newBuildObserver(getBuild().getId()));
}
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/log/BuildStepsPage.html b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/log/BuildStepsPage.html
index 990619dd38..06dba75870 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/log/BuildStepsPage.html
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/log/BuildStepsPage.html
@@ -17,8 +17,10 @@
<wicket:fragment wicket:id="optionsFrag">
<div class="d-flex align-items-center">
<span wicket:id="stickyActions" class="build-step-sticky-actions align-items-center">
+ <a wicket:id="rebuild" class="btn btn-icon btn-light btn-hover-primary btn-xs mr-2" t:data-tippy-content="Re-run this build" t:aria-label="Re-run this build"><wicket:svg href="re-run" class="icon"/></a>
<a wicket:id="cancel" class="btn btn-icon btn-light btn-hover-danger btn-xs mr-2" t:data-tippy-content="Cancel this build" t:aria-label="Cancel this build"><wicket:svg href="cancel" class="icon"/></a>
<a wicket:id="terminal" class="subscription-required btn btn-icon btn-light btn-hover-primary btn-xs mr-2" t:data-tippy-content="Open terminal of current running step" t:aria-label="Open terminal of current running step"><wicket:svg href="terminal" class="icon"/></a>
+ <a wicket:id="createIssue" class="btn btn-icon btn-light btn-hover-primary btn-xs mr-2" t:data-tippy-content="Create an issue for this failure" t:aria-label="Create an issue for this failure"><wicket:svg href="issue" class="icon"/></a>
</span>
<a wicket:id="download" class="btn btn-light btn-hover-primary btn-icon btn-sm btn-xs" t:data-tippy-content="Download full log" t:aria-label="Download full log"><wicket:svg href="download" class="icon"/></a>
</div>
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/log/BuildStepsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/log/BuildStepsPage.java
index 2f502f7191..f4cf72f7de 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/log/BuildStepsPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/log/BuildStepsPage.java
@@ -318,7 +318,8 @@ public class BuildStepsPage extends BuildDetailPage {
public Component renderOptions(String componentId) {
var fragment = new Fragment(componentId, "optionsFrag", this);
var stickyActions = new WebMarkupContainer("stickyActions");
- stickyActions.add(newCancelLink("cancel"), newTerminalLink("terminal"));
+ stickyActions.add(newRebuildLink("rebuild"), newCancelLink("cancel"),
+ newTerminalLink("terminal"), newCreateIssueLink("createIssue"));
stickyActions.add(newBuildObserver(getBuild().getId()));
fragment.add(stickyActions);
fragment.add(new ResourceLink<Void>("download", new BuildLogResourceReference(),