Skip to content

The Unified and Autonomous Development Platform

fix: Avoid resubmitting successful upstream jobs on dependent rerun

Robin Shen2f6340c6ad3c
diff --git a/server-core/src/main/java/io/onedev/server/job/DefaultJobService.java b/server-core/src/main/java/io/onedev/server/job/DefaultJobService.java
index 7d51cbfb27..0d0917516e 100644
--- a/server-core/src/main/java/io/onedev/server/job/DefaultJobService.java
+++ b/server-core/src/main/java/io/onedev/server/job/DefaultJobService.java
@@ -865,8 +865,9 @@ public class DefaultJobService implements JobService, Runnable, CodePullAuthoriz
var systemUser = userService.getSystem();
for (var dependence : build.getDependencies()) {
- var dependency = dependence.getDependency();
- resubmit(systemUser, dependency, "Resubmitted by dependent build");
+ var dependency = dependence.getDependency();
+ if (dependence.isRequireSuccessful() && !dependency.isSuccessful())
+ resubmit(systemUser, dependency, "Resubmitted by dependent build");
}
}
}