Skip to content

The Unified and Autonomous Development Platform

chore: Terminal access should be invisible when build is cancelled

Robin Shen2f6656d74ab5
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java
index 7fe5dc7e4f..b73fef72d9 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java
@@ -362,7 +362,7 @@ public abstract class BuildDetailPage extends ProjectPage
super.onConfigure();
JobContext jobContext = jobService.getJobContext(getBuild().getId());
- setVisible(jobContext!= null && SecurityUtils.canOpenTerminal(getBuild()));
+ setVisible(jobContext!= null && !getBuild().isFinished() && SecurityUtils.canOpenTerminal(getBuild()));
}
}.setOutputMarkupId(true));