Skip to content

The Unified and Autonomous Development Platform

Fix issue #963 - Crash when input '@' in image field of build spec

Robin Shen415719939153
diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/CommandStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/CommandStep.java
index 80ce7e162b..33fb07b4d1 100644
--- a/server-core/src/main/java/io/onedev/server/buildspec/step/CommandStep.java
+++ b/server-core/src/main/java/io/onedev/server/buildspec/step/CommandStep.java
@@ -2,9 +2,13 @@ package io.onedev.server.buildspec.step;
import javax.validation.constraints.NotNull;
+import java.util.List;
+
import javax.validation.constraints.NotEmpty;
+import io.onedev.commons.codeassist.InputSuggestion;
import io.onedev.k8shelper.StepFacade;
+import io.onedev.server.buildspec.BuildSpec;
import io.onedev.server.buildspec.param.ParamCombination;
import io.onedev.server.buildspec.step.commandinterpreter.DefaultInterpreter;
import io.onedev.server.buildspec.step.commandinterpreter.Interpreter;
@@ -58,6 +62,10 @@ public class CommandStep extends Step {
this.image = image;
}
+ static List<InputSuggestion> suggestVariables(String matchWith) {
+ return BuildSpec.suggestVariables(matchWith, false, false, false);
+ }
+
@Editable(order=110)
@NotNull
public Interpreter getInterpreter() {