Skip to content

The Unified and Autonomous Development Platform

chore: Remove copy button from issue title to be cleaner

Robin Shen45f4e1841fe9
diff --git a/server-core/src/main/java/io/onedev/server/entityreference/PullRequestReference.java b/server-core/src/main/java/io/onedev/server/entityreference/PullRequestReference.java
index d4b8618f8a..fe3adf9522 100644
--- a/server-core/src/main/java/io/onedev/server/entityreference/PullRequestReference.java
+++ b/server-core/src/main/java/io/onedev/server/entityreference/PullRequestReference.java
@@ -8,7 +8,7 @@ public class PullRequestReference extends EntityReference {
private static final long serialVersionUID = 1L;
- public static final String TYPE = "pull request";
+ public static final String TYPE = "pr";
public PullRequestReference(Project project, Long number) {
super(project, number);
diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/editabletitle/IssueEditableTitlePanel.html b/server-core/src/main/java/io/onedev/server/web/component/issue/editabletitle/IssueEditableTitlePanel.html
index 03386baae7..cd51a6b2d6 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/issue/editabletitle/IssueEditableTitlePanel.html
+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/editabletitle/IssueEditableTitlePanel.html
@@ -15,7 +15,6 @@
<span wicket:id="title"></span>
<span wicket:id="number" class="number ml-2 mr-2 text-muted"></span>
<span wicket:id="confidential" t:data-tippy-content="Confidential" class="text-warning mr-2"><wicket:svg href="incognito" class="icon icon-lg"/></span>
- <a wicket:id="copy" class="btn btn-xs btn-icon btn-light btn-hover-primary copy flex-shrink-0 mr-2"><wicket:svg href="copy" class="icon"></wicket:svg></a>
<a wicket:id="edit" class="btn btn-xs btn-icon btn-light btn-hover-primary edit flex-shrink-0 mr-2" t:data-tippy-content="Edit issue title"><wicket:svg href="edit" class="icon"></wicket:svg></a>
<span wicket:id="progress" class="d-flex align-items-center mr-2"></span>
</wicket:fragment>
diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/editabletitle/IssueEditableTitlePanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/editabletitle/IssueEditableTitlePanel.java
index d9065b513c..6465b8c024 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/issue/editabletitle/IssueEditableTitlePanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/editabletitle/IssueEditableTitlePanel.java
@@ -9,7 +9,6 @@ import io.onedev.server.security.SecurityUtils;
import io.onedev.server.web.asset.emoji.Emojis;
import io.onedev.server.web.behavior.ReferenceInputBehavior;
import io.onedev.server.web.component.issue.progress.IssueProgressPanel;
-import io.onedev.server.web.component.link.copytoclipboard.CopyToClipboardLink;
import io.onedev.server.web.page.base.BasePage;
import org.apache.wicket.ajax.AjaxRequestTarget;
import org.apache.wicket.ajax.markup.html.AjaxLink;
@@ -151,9 +150,6 @@ public abstract class IssueEditableTitlePanel extends Panel {
});
- titleViewer.add(new CopyToClipboardLink("copy",
- Model.of(getIssue().getTitle() + " (" + getIssue().getReference().toString(getProject()) + ")")));
-
titleViewer.add(new IssueProgressPanel("progress") {
@Override
@@ -182,7 +178,5 @@ public abstract class IssueEditableTitlePanel extends Panel {
}
protected abstract Issue getIssue();
-
- protected abstract Project getProject();
-
+
}
diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/list/IssueListPanel.html b/server-core/src/main/java/io/onedev/server/web/component/issue/list/IssueListPanel.html
index 168f12ebd7..0cd3374cee 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/issue/list/IssueListPanel.html
+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/list/IssueListPanel.html
@@ -58,9 +58,6 @@
<div class="primary d-flex mb-3">
<div class="mr-4 flex-grow-1 d-flex flex-wrap dropdown-aware row-gap-2">
<span wicket:id="numberAndTitle" class="mr-2"></span>
- <a wicket:id="copy" t:data-tippy-content="Copy issue number and title" class="copy mr-2 btn btn-icon btn-xs btn-light btn-hover-primary">
- <wicket:svg href="copy" class="icon"/>
- </a>
<span wicket:id="progress" class="d-flex align-items-center mr-2"></span>
<a wicket:id="workspaces" class="workspaces mr-2 btn btn-icon btn-xs btn-light btn-hover-primary" t:data-tippy-content="Workspaces on this issue"><wicket:svg href="workspace" class="icon"/></a>
<a wicket:id="pin" t:data-tippy-content="Pin this issue" class="pin mr-2 btn btn-icon btn-xs btn-light btn-hover-primary">
@@ -117,4 +114,4 @@
</form>
</div>
</wicket:fragment>
-</wicket:panel>
\ No newline at end of file
+</wicket:panel>
diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/list/IssueListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/list/IssueListPanel.java
index 7733a558e6..438c3cabc1 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/issue/list/IssueListPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/list/IssueListPanel.java
@@ -130,7 +130,6 @@ import io.onedev.server.web.component.issue.progress.QueriedIssuesProgressPanel;
import io.onedev.server.web.component.issue.title.IssueTitlePanel;
import io.onedev.server.web.component.issue.workspaces.IssueWorkspacesLink;
import io.onedev.server.web.component.link.DropdownLink;
-import io.onedev.server.web.component.link.copytoclipboard.CopyToClipboardLink;
import io.onedev.server.web.component.menu.MenuItem;
import io.onedev.server.web.component.menu.MenuLink;
import io.onedev.server.web.component.modal.ModalLink;
@@ -1978,9 +1977,6 @@ public abstract class IssueListPanel extends Panel {
});
- fragment.add(new CopyToClipboardLink("copy",
- Model.of(issue.getTitle() + " (" + issue.getReference().toString(getProject()) + ")")));
-
fragment.add(new IssueWorkspacesLink("workspaces") {
@Override
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardCardPanel.html b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardCardPanel.html
index fd33eaa081..8009c5465a 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardCardPanel.html
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardCardPanel.html
@@ -4,7 +4,6 @@
<div class="issue-item">
<div class="primary d-flex align-items-center flex-wrap dropdown-aware row-gap-2 mb-3">
<span wicket:id="numberAndTitle" class="font-weight-bold mr-1"></span>
- <a wicket:id="copy" class="btn btn-xs btn-icon btn-light btn-hover-primary copy flex-shrink-0 mr-2" t:data-tippy-content="Copy issue number and title"><wicket:svg href="copy" class="icon"></wicket:svg></a>
<div wicket:id="progress" class="d-flex align-items-center mr-2"></div>
<a wicket:id="workspaces" class="btn btn-xs btn-icon btn-light btn-hover-primary workspaces flex-shrink-0 mr-2" t:data-tippy-content="Workspaces on this issue"><wicket:svg href="workspace" class="icon"></wicket:svg></a>
<a wicket:id="showDetail" t:data-tippy-content="Click to show issue details" class="show-detail"><wicket:svg href="ellipsis" class="icon"/></a>
@@ -30,4 +29,4 @@
<wicket:fragment wicket:id="stateFrag">
<div wicket:id="transit" class="state"><span wicket:id="state" class="mb-2 mr-2"></span></div>
</wicket:fragment>
-</wicket:panel>
\ No newline at end of file
+</wicket:panel>
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardCardPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardCardPanel.java
index ea7c734679..5d40e94d4e 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardCardPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardCardPanel.java
@@ -29,7 +29,6 @@ import org.apache.wicket.markup.html.panel.GenericPanel;
import org.apache.wicket.markup.repeater.RepeatingView;
import org.apache.wicket.model.IModel;
import org.apache.wicket.model.LoadableDetachableModel;
-import org.apache.wicket.model.Model;
import org.apache.wicket.request.cycle.RequestCycle;
import org.hibernate.Hibernate;
@@ -54,7 +53,6 @@ import io.onedev.server.web.component.issue.operation.TransitionMenuLink;
import io.onedev.server.web.component.issue.progress.IssueProgressPanel;
import io.onedev.server.web.component.issue.title.IssueTitlePanel;
import io.onedev.server.web.component.issue.workspaces.IssueWorkspacesLink;
-import io.onedev.server.web.component.link.copytoclipboard.CopyToClipboardLink;
import io.onedev.server.web.component.modal.ModalLink;
import io.onedev.server.web.component.modal.ModalPanel;
import io.onedev.server.web.component.user.ident.Mode;
@@ -275,9 +273,6 @@ public abstract class BoardCardPanel extends GenericPanel<Issue> {
});
- fragment.add(new CopyToClipboardLink("copy",
- Model.of(issue.getTitle() + " (" + issue.getReference().toString(getProject()) + ")")));
-
fragment.add(new IssueWorkspacesLink("workspaces") {
@Override
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/CardDetailPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/CardDetailPanel.java
index 40dee70ebe..25439cbbb8 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/CardDetailPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/CardDetailPanel.java
@@ -92,11 +92,6 @@ abstract class CardDetailPanel extends GenericPanel<Issue> implements InputConte
return CardDetailPanel.this.getIssue();
}
- @Override
- protected Project getProject() {
- return CardDetailPanel.this.getProject();
- }
-
});
add(new SideInfoLink("moreInfoTrigger"));
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.java
index 365197df91..dcdcbe027f 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.java
@@ -149,11 +149,6 @@ public abstract class IssueDetailPage extends ProjectIssuesPage implements Input
return IssueDetailPage.this.getIssue();
}
- @Override
- protected Project getProject() {
- return getIssue().getProject();
- }
-
});
add(new SideInfoLink("moreInfo"));
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/list/ProjectIssueListPage.html b/server-core/src/main/java/io/onedev/server/web/page/project/issues/list/ProjectIssueListPage.html
index a922618b0b..f09870728d 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/list/ProjectIssueListPage.html
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/list/ProjectIssueListPage.html
@@ -11,9 +11,6 @@
<wicket:fragment wicket:id="pinnedIssueFrag">
<div class="primary d-flex align-items-center flex-wrap row-gap-2 position-relative mb-3">
<span wicket:id="numberAndTitle" class="mr-2"></span>
- <a wicket:id="copy" t:data-tippy-content="Copy issue number and title" class="copy mr-2 btn btn-icon btn-xs btn-light btn-hover-primary">
- <wicket:svg href="copy" class="icon"/>
- </a>
<span wicket:id="progress" class="d-flex align-items-center mr-2"></span>
<span wicket:id="links" class="links d-flex align-items-center"/>
<a wicket:id="unpin" t:data-tippy-content="Unpin this issue" class="unpin btn btn-icon btn-xs btn-light btn-hover-primary"><wicket:svg href="unpin" class="icon flip-x"/></a>
@@ -30,4 +27,4 @@
<wicket:fragment wicket:id="stateFrag">
<div wicket:id="transit" class="state"><span wicket:id="state"></span></div>
</wicket:fragment>
-</wicket:extend>
\ No newline at end of file
+</wicket:extend>
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/list/ProjectIssueListPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/list/ProjectIssueListPage.java
index c80ba45466..f743534105 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/list/ProjectIssueListPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/list/ProjectIssueListPage.java
@@ -30,7 +30,6 @@ import org.apache.wicket.markup.html.panel.Fragment;
import org.apache.wicket.markup.repeater.RepeatingView;
import org.apache.wicket.model.IModel;
import org.apache.wicket.model.LoadableDetachableModel;
-import org.apache.wicket.model.Model;
import org.apache.wicket.request.cycle.RequestCycle;
import org.apache.wicket.request.mapper.parameter.PageParameters;
@@ -64,7 +63,6 @@ import io.onedev.server.web.component.issue.operation.TransitionMenuLink;
import io.onedev.server.web.component.issue.progress.IssueProgressPanel;
import io.onedev.server.web.component.issue.title.IssueTitlePanel;
import io.onedev.server.web.component.link.ViewStateAwarePageLink;
-import io.onedev.server.web.component.link.copytoclipboard.CopyToClipboardLink;
import io.onedev.server.web.component.modal.ModalPanel;
import io.onedev.server.web.component.savedquery.NamedQueriesBean;
import io.onedev.server.web.component.savedquery.PersonalQuerySupport;
@@ -227,9 +225,6 @@ public class ProjectIssueListPage extends ProjectIssuesPage {
});
- fragment.add(new CopyToClipboardLink("copy",
- Model.of(issue.getTitle() + " (#" + issue.getNumber() + ")")));
-
var linksPanel = new IssueLinksPanel("links") {
@Override