Skip to content

The Unified and Autonomous Development Platform

Fix issue #484 - Issue creation error from Board with default milestone

Robin Shen4ed79861d7ad
diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/CommandStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/CommandStep.java
index c402d3d7fd..d927dde0c7 100644
--- a/server-core/src/main/java/io/onedev/server/buildspec/step/CommandStep.java
+++ b/server-core/src/main/java/io/onedev/server/buildspec/step/CommandStep.java
@@ -41,7 +41,7 @@ public class CommandStep extends Step {
}
@Editable(order=110, description="Specify content of Linux shell script or Windows command batch to execute "
- + "under the <a href='$docRoot/pages/concepts.md#job-workspace'>job workspace</a>. Depending on the "
+ + "under the <a href='$docRoot/pages/concepts.md#job-workspace' target='_blank'>job workspace</a>. Depending on the "
+ "job executor being used, this may be executed either inside or outside container")
@Interpolative
@Code(language=Code.SHELL, variableProvider="suggestCommandVariables")
diff --git a/server-core/src/main/java/io/onedev/server/model/support/issue/BoardSpec.java b/server-core/src/main/java/io/onedev/server/model/support/issue/BoardSpec.java
index f24a583ec5..c208d65d05 100644
--- a/server-core/src/main/java/io/onedev/server/model/support/issue/BoardSpec.java
+++ b/server-core/src/main/java/io/onedev/server/model/support/issue/BoardSpec.java
@@ -100,7 +100,8 @@ public class BoardSpec implements Serializable {
this.backlogBaseQuery = backlogBaseQuery;
}
- @Editable(order=300, description="Specify issue field to identify different columns of the board")
+ @Editable(order=300, description="Specify issue field to identify different columns of the board. "
+ + "Only state and single-valued enumeration field can be used here")
@ChoiceProvider("getIdentifyFieldChoices")
@NotEmpty
public String getIdentifyField() {
diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/create/NewIssueEditor.java b/server-core/src/main/java/io/onedev/server/web/component/issue/create/NewIssueEditor.java
index fabe0cd161..4fd1351d67 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/issue/create/NewIssueEditor.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/create/NewIssueEditor.java
@@ -284,17 +284,20 @@ public abstract class NewIssueEditor extends FormComponentPanel<Issue> implement
Issue issue = newIssue();
issue.setTitle(titleInput.getConvertedInput());
issue.setDescription(descriptionInput.getConvertedInput());
- for (Milestone milestone: milestoneChoice.getConvertedInput()) {
- IssueSchedule schedule = new IssueSchedule();
- schedule.setMilestone(milestone);
- schedule.setIssue(issue);
- issue.getSchedules().add(schedule);
- }
fieldEditor.convertInput();
Collection<String> fieldNames = getIssueSetting().getPromptFieldsUponIssueOpen(getProject());
issue.setFieldValues(FieldUtils.getFieldValues(fieldEditor.newComponentContext(),
fieldEditor.getConvertedInput(), fieldNames));
+
+ milestoneChoice.convertInput();
+ issue.getSchedules().clear();
+ for (Milestone milestone: milestoneChoice.getConvertedInput()) {
+ IssueSchedule schedule = new IssueSchedule();
+ schedule.setIssue(issue);
+ schedule.setMilestone(milestone);
+ issue.getSchedules().add(schedule);
+ }
return issue;
}