Skip to content

The Unified and Autonomous Development Platform

Hide pull request side info when add/open comment over the diff

Robin Shen55233dc29aa4
diff --git a/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java b/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java
index 192645c925..ead797e366 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java
@@ -1245,6 +1245,7 @@ public abstract class RevisionDiffPanel extends Panel {
if (blobDiffPanel != null)
blobDiffPanel.onCommentClosed(target);
annotationSupport.onCommentClosed(target);
+ target.prependJavaScript("$('body').removeClass('hide-side-info');");
}
});
diff --git a/server-core/src/main/java/io/onedev/server/web/component/diff/revision/revision-diff.js b/server-core/src/main/java/io/onedev/server/web/component/diff/revision/revision-diff.js
index ef8f2d5f5e..cb41ec9e07 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/diff/revision/revision-diff.js
+++ b/server-core/src/main/java/io/onedev/server/web/component/diff/revision/revision-diff.js
@@ -18,8 +18,8 @@ onedev.server.revisionDiff = {
},
initComment: function() {
var $comment = $(".revision-diff>.body>.detail>.comment");
-
if ($comment.is(":visible")) {
+ $("body").addClass("hide-side-info");
var $commentResizeHandle = $comment.children(".ui-resizable-handle");
$comment.resizable({
autoHide: false,
diff --git a/server-core/src/main/java/io/onedev/server/web/component/sideinfo/side-info.css b/server-core/src/main/java/io/onedev/server/web/component/sideinfo/side-info.css
index 30e80453c9..70dbb933d2 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/sideinfo/side-info.css
+++ b/server-core/src/main/java/io/onedev/server/web/component/sideinfo/side-info.css
@@ -24,7 +24,7 @@ a.side-info {
display: none;
align-items: center;
}
-@media(max-width: 1199px) {
+@media(max-width: 1350px) {
div.side-info {
box-shadow: 0px 0px 8px 0px rgba(0,0,0,0.1);
border-left: none;
@@ -49,3 +49,27 @@ a.side-info {
display: inline-flex;
}
}
+
+.hide-side-info div.side-info {
+ box-shadow: 0px 0px 8px 0px rgba(0,0,0,0.1);
+ border-left: none;
+ position: fixed;
+ right: 0;
+ top: 0;
+ bottom: 0;
+ z-index: 1050;
+ margin: 0;
+}
+.hide-side-info div.side-info.closed {
+ right: -360px;
+ box-shadow: none;
+}
+.hide-side-info div.side-info>.header .close {
+ display: flex;
+}
+.hide-side-info div.side-info>.body {
+ overflow: auto;
+}
+.hide-side-info a.side-info {
+ display: inline-flex;
+}