Skip to content

The Unified and Autonomous Development Platform

feat: make SideInfoPanel sticky on wide viewports

Work Horse5d8243f1e4b2
diff --git a/server-core/src/main/java/io/onedev/server/web/component/sideinfo/side-info.css b/server-core/src/main/java/io/onedev/server/web/component/sideinfo/side-info.css
index ac9bedf8d3..ea7221a152 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/sideinfo/side-info.css
+++ b/server-core/src/main/java/io/onedev/server/web/component/sideinfo/side-info.css
@@ -40,13 +40,19 @@ a.side-info {
display: none;
}
-/* Collapsed pinned pane on wide viewports (non-overlay layouts) */
+/* Pinned pane on wide viewports (non-overlay layouts): stick under top
+ chrome while sharing the page scroller — no inner scrollbar / max-height.
+ top: 0 is relative to .autofit, which already sits below the fixed topbar. */
@media(min-width: 1199px) {
+ div.side-info {
+ position: sticky;
+ top: 0;
+ align-self: flex-start;
+ }
div.side-info.closed {
width: 0;
max-height: 0;
min-height: 0;
- align-self: flex-start;
margin: 0;
border-left: none;
overflow: hidden;
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.html b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.html
index 1a8b693543..af596514e0 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.html
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.html
@@ -1,10 +1,10 @@
<wicket:extend>
- <div class="card position-relative overflow-hidden issue-detail">
+ <div class="card position-relative issue-detail">
<div class="card-header d-flex align-items-center flex-nowrap">
<div wicket:id="title" class="card-title flex-grow-1 mx-0"></div>
<a wicket:id="moreInfo" class="more-info side-info flex-shrink-0 ml-3" t:data-tippy-content="More info"><wicket:svg href="ellipsis" class="icon"></wicket:svg></a>
</div>
- <div class="card-body d-flex position-relative overflow-hidden">
+ <div class="card-body d-flex position-relative">
<div class="main flex-grow-1">
<div wicket:id="operations" class="mb-5"></div>
<div wicket:id="primary" class="mb-5"></div>