Skip to content

The Unified and Autonomous Development Platform

Fix issue #1229 - Pull request should not send minor notifications such as referenced from other places

Robin Shen6c33b38c7ee1
diff --git a/server-core/src/main/java/io/onedev/server/event/project/pullrequest/PullRequestChanged.java b/server-core/src/main/java/io/onedev/server/event/project/pullrequest/PullRequestChanged.java
index 5ee8fc541d..32174fecff 100644
--- a/server-core/src/main/java/io/onedev/server/event/project/pullrequest/PullRequestChanged.java
+++ b/server-core/src/main/java/io/onedev/server/event/project/pullrequest/PullRequestChanged.java
@@ -71,4 +71,9 @@ public class PullRequestChanged extends PullRequestEvent implements CommitAware
return OneDev.getInstance(UrlManager.class).urlFor(getChange());
}
+ @Override
+ public boolean isMinor() {
+ return getChange().isMinor();
+ }
+
}
diff --git a/server-core/src/main/java/io/onedev/server/model/PullRequestChange.java b/server-core/src/main/java/io/onedev/server/model/PullRequestChange.java
index 22ef182cd0..ed6d64d5fb 100644
--- a/server-core/src/main/java/io/onedev/server/model/PullRequestChange.java
+++ b/server-core/src/main/java/io/onedev/server/model/PullRequestChange.java
@@ -11,8 +11,6 @@ import java.util.Date;
public class PullRequestChange extends AbstractEntity {
private static final long serialVersionUID = 1L;
-
- public static final int DIFF_CONTEXT_SIZE = 3;
@ManyToOne
@JoinColumn(nullable=false)
@@ -65,4 +63,8 @@ public class PullRequestChange extends AbstractEntity {
return getClass().getSimpleName() + "-" + getId();
}
+ public boolean isMinor() {
+ return getData().isMinor();
+ }
+
}