The Unified and Autonomous Development Platform
feat: Add migration logic
Robin Shen74fd668e910c
diff --git a/server-core/src/main/java/io/onedev/server/buildspec/BuildSpec.java b/server-core/src/main/java/io/onedev/server/buildspec/BuildSpec.javaindex 359a6e3f37..a8cea00648 100644--- a/server-core/src/main/java/io/onedev/server/buildspec/BuildSpec.java+++ b/server-core/src/main/java/io/onedev/server/buildspec/BuildSpec.java@@ -174,7 +174,6 @@ public class BuildSpec implements Serializable, Validatable {importedBuildSpecs.add(importedBuildSpec);}} catch (Exception e) {- e.printStackTrace();// Ignore here as we rely on this method to show viewer/editor// Errors relating to this will be shown when validated}@@ -1969,7 +1968,8 @@ public class BuildSpec implements Serializable, Validatable {migrateSteps(doc, versions, stepsNode -> {for (var itStepNode = stepsNode.getValue().iterator(); itStepNode.hasNext();) {MappingNode stepNode = (MappingNode) itStepNode.next();- if (stepNode.getTag().getValue().equals("!PullRepository")) {+ var stepType = stepNode.getTag().getValue();+ if (stepType.equals("!PullRepository")) {boolean syncToChild = false;String childProject = null;for (var itStepTuple = stepNode.getValue().iterator(); itStepTuple.hasNext();) {@@ -1989,6 +1989,12 @@ public class BuildSpec implements Serializable, Validatable {new ScalarNode(Tag.STR, "targetProject"),new ScalarNode(Tag.STR, targetProject)));}+ } else if (stepType.equals("!PublishCPDReportStep") || stepType.equals("!PublishCheckstyleReportStep")+ || stepType.equals("!PublishESLintReportStep") || stepType.equals("!PublishPMDReportStep")+ || stepType.equals("!PublishRoslynatorReportStep") || stepType.equals("!PublishSpotBugsReportStep")) {+ stepNode.getValue().add(new NodeTuple(+ new ScalarNode(Tag.STR, "failThreshold"),+ new ScalarNode(Tag.STR, "HIGH")));}}});diff --git a/server-core/src/main/java/io/onedev/server/data/migration/DataMigrator.java b/server-core/src/main/java/io/onedev/server/data/migration/DataMigrator.javaindex 43f467027c..4b38384c70 100644--- a/server-core/src/main/java/io/onedev/server/data/migration/DataMigrator.java+++ b/server-core/src/main/java/io/onedev/server/data/migration/DataMigrator.java@@ -6283,5 +6283,17 @@ public class DataMigrator {dom.writeToFile(file, false);}}- }+ }++ private void migrate159(File dataDir, Stack<Integer> versions) {+ for (File file : dataDir.listFiles()) {+ if (file.getName().startsWith("ProblemMetrics.xml")) {+ VersionedXmlDoc dom = VersionedXmlDoc.fromFile(file);+ for (Element element : dom.getRootElement().elements())+ element.addElement("criticalSeverities").setText("0");+ dom.writeToFile(file, false);+ }+ }+ }+}\ No newline at end of filediff --git a/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/PublishProblemReportStep.java b/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/PublishProblemReportStep.javaindex cc9b575f2f..4449ffeca7 100644--- a/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/PublishProblemReportStep.java+++ b/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/PublishProblemReportStep.java@@ -34,7 +34,8 @@ public abstract class PublishProblemReportStep extends PublishReportStep {private Severity failThreshold = HIGH;@Editable(order=1000, name="Fail Threshold", description = "Fail build if there are vulnerabilities " +- "with or severer than specified severity level")+ "with or severer than specified severity level. Note that this only takes effect if build " ++ "is not failed by other steps")@NotNullpublic Severity getFailThreshold() {return failThreshold;