Skip to content

The Unified and Autonomous Development Platform

Fix the security vulnerability caused by message interpolator of jersey validator

Robin Shen7c15bf791c0d
diff --git a/server-core/src/main/java/io/onedev/server/rest/jersey/ValidationConfigurationContextResolver.java b/server-core/src/main/java/io/onedev/server/rest/jersey/ValidationConfigurationContextResolver.java
index e32bd0aac0..7c8650e891 100644
--- a/server-core/src/main/java/io/onedev/server/rest/jersey/ValidationConfigurationContextResolver.java
+++ b/server-core/src/main/java/io/onedev/server/rest/jersey/ValidationConfigurationContextResolver.java
@@ -1,19 +1,27 @@
package io.onedev.server.rest.jersey;
import javax.validation.ValidatorFactory;
+import javax.ws.rs.container.ResourceContext;
+import javax.ws.rs.core.Context;
import javax.ws.rs.ext.ContextResolver;
+import javax.ws.rs.ext.Provider;
import org.glassfish.jersey.server.validation.ValidationConfig;
+import org.glassfish.jersey.server.validation.internal.InjectingConstraintValidatorFactory;
import io.onedev.commons.launcher.loader.AppLoader;
+@Provider
public class ValidationConfigurationContextResolver implements ContextResolver<ValidationConfig> {
+ @Context
+ private ResourceContext resourceContext;
+
@Override
public ValidationConfig getContext(final Class<?> type) {
ValidatorFactory factory = AppLoader.getInstance(ValidatorFactory.class);
ValidationConfig config = new ValidationConfig();
- config.constraintValidatorFactory(factory.getConstraintValidatorFactory());
+ config.constraintValidatorFactory(resourceContext.getResource(InjectingConstraintValidatorFactory.class));
config.messageInterpolator(factory.getMessageInterpolator());
config.parameterNameProvider(factory.getParameterNameProvider());
config.traversableResolver(factory.getTraversableResolver());