Skip to content

The Unified and Autonomous Development Platform

Remember comment width without refreshing page

Richard Rao7e55bbd70307
diff --git a/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java b/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java
index 71913f9222..85d1f34a41 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java
@@ -1413,15 +1413,21 @@ public abstract class RevisionDiffPanel extends Panel {
};
commentContainer.setOutputMarkupPlaceholderTag(true);
- float commentWidth;
- WebRequest request = (WebRequest) RequestCycle.get().getRequest();
- Cookie cookie = request.getCookie(COOKIE_COMMENT_WIDTH);
- if (cookie != null)
- commentWidth = Float.parseFloat(cookie.getValue());
- else
- commentWidth = 300;
-
- commentContainer.add(AttributeAppender.append("style", "width:" + commentWidth + "px"));
+ commentContainer.add(AttributeAppender.append("style", new LoadableDetachableModel<String>() {
+
+ @Override
+ protected String load() {
+ float commentWidth;
+ WebRequest request = (WebRequest) RequestCycle.get().getRequest();
+ Cookie cookie = request.getCookie(COOKIE_COMMENT_WIDTH);
+ if (cookie != null)
+ commentWidth = Float.parseFloat(cookie.getValue());
+ else
+ commentWidth = 300;
+ return "width:" + commentWidth + "px";
+ }
+
+ }));
WebMarkupContainer head = new WebMarkupContainer("head");
head.setOutputMarkupId(true);